From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XD562-0003Dv-5g for qemu-devel@nongnu.org; Fri, 01 Aug 2014 01:09:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XD55w-0004vJ-1V for qemu-devel@nongnu.org; Fri, 01 Aug 2014 01:09:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XD55v-0004vB-Pi for qemu-devel@nongnu.org; Fri, 01 Aug 2014 01:09:31 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7159UaV015375 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 1 Aug 2014 01:09:30 -0400 Date: Fri, 1 Aug 2014 10:39:09 +0530 From: Amit Shah Message-ID: <20140801050909.GA12029@grmbl.mre> References: <1406676538-23149-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1406676538-23149-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] virtio-rng: Fix memory leaks in virtio_rng_device_realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com On (Tue) 29 Jul 2014 [19:28:56], John Snow wrote: > My previous commit, 713e8a10, did not address the fact that > the error checking pathways do not attempt to call > virtio_cleanup and thus can leak memory in hotplug scenarios. > > This patchset shuffles around the error checking so it does not > need to perform said cleanup, and changes the error functions > from error_set to error_setg. Thanks, queued up for 2.2. Amit