From: Stefan Hajnoczi <stefanha@gmail.com>
To: Maria Kustova <maxa@catit.be>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, Maria Kustova <maria.k@catit.be>
Subject: Re: [Qemu-devel] [PATCH 4/4] layout: Add generators of L1/L2 tables
Date: Fri, 1 Aug 2014 06:34:22 +0100 [thread overview]
Message-ID: <20140801053422.GA6875@stefanha-thinkpad.lan> (raw)
In-Reply-To: <593818ece5570e905c966e04bea55c63cdddbbf0.1406204552.git.maria.k@catit.be>
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
On Thu, Jul 24, 2014 at 04:32:29PM +0400, Maria Kustova wrote:
> ['>I', offset, 0x6803f857, 'ext_magic'],
> - ['>I', offset + UINT32_S, len(feature_tables)*48, 'ext_length']
> + # Length of one feature table equals to 3 fields and 48 bytes
> + ['>I', offset + UINT32_S, len(feature_tables)/3*48,
Please use spaces around operators in arithmetic expressions:
len(feature_tables) / 3 * 48
There are other instances of missing space in this patch.
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-08-01 5:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 12:32 [Qemu-devel] [PATCH 0/4] image-fuzzer: Support L1/L2 tables in the qcow2 image generator Maria Kustova
2014-07-24 12:32 ` [Qemu-devel] [PATCH 1/4] docs: Expand the list of supported image elements with L1/L2 tables Maria Kustova
2014-07-30 8:12 ` Fam Zheng
2014-07-24 12:32 ` [Qemu-devel] [PATCH 2/4] runner: Make a copy of a test image for destructive test commands Maria Kustova
2014-07-30 8:49 ` Fam Zheng
2014-07-24 12:32 ` [Qemu-devel] [PATCH 3/4] fuzz: Add fuzzing functions for L1/L2 table entries Maria Kustova
2014-07-24 12:32 ` [Qemu-devel] [PATCH 4/4] layout: Add generators of L1/L2 tables Maria Kustova
2014-08-01 5:34 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140801053422.GA6875@stefanha-thinkpad.lan \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=maria.k@catit.be \
--cc=maxa@catit.be \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).