From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38854)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XD5UC-0001nc-OZ
	for qemu-devel@nongnu.org; Fri, 01 Aug 2014 01:34:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XD5U3-0006IM-Nq
	for qemu-devel@nongnu.org; Fri, 01 Aug 2014 01:34:36 -0400
Received: from mail-we0-x233.google.com ([2a00:1450:400c:c03::233]:38236)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XD5U3-0006HY-AW
	for qemu-devel@nongnu.org; Fri, 01 Aug 2014 01:34:27 -0400
Received: by mail-we0-f179.google.com with SMTP id u57so3716920wes.38
	for <qemu-devel@nongnu.org>; Thu, 31 Jul 2014 22:34:26 -0700 (PDT)
Date: Fri, 1 Aug 2014 06:34:22 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140801053422.GA6875@stefanha-thinkpad.lan>
References: <cover.1406204552.git.maria.k@catit.be>
	<593818ece5570e905c966e04bea55c63cdddbbf0.1406204552.git.maria.k@catit.be>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="wac7ysb48OaltWcw"
Content-Disposition: inline
In-Reply-To: <593818ece5570e905c966e04bea55c63cdddbbf0.1406204552.git.maria.k@catit.be>
Subject: Re: [Qemu-devel] [PATCH 4/4] layout: Add generators of L1/L2 tables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Maria Kustova <maxa@catit.be>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, Maria Kustova <maria.k@catit.be>


--wac7ysb48OaltWcw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jul 24, 2014 at 04:32:29PM +0400, Maria Kustova wrote:
>                  ['>I', offset, 0x6803f857, 'ext_magic'],
> -                ['>I', offset + UINT32_S, len(feature_tables)*48, 'ext_length']
> +                # Length of one feature table equals to 3 fields and 48 bytes
> +                ['>I', offset + UINT32_S, len(feature_tables)/3*48,

Please use spaces around operators in arithmetic expressions:

len(feature_tables) / 3 * 48

There are other instances of missing space in this patch.

--wac7ysb48OaltWcw
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJT2ybeAAoJEJykq7OBq3PIpVsIAMH1fiBlhv2Zkp3/0Av50enw
+IdgiNux1JwnX2O2sOTrZ5E7mNREWiIvSzp2A1wOesmRylhRCEDljOaS+hror9jG
hTRIFlRB3Js22tb17RqkMwUIr/PUL+enaMKdYx3XugnvsXoMAr/ZoCl+Cy+IJGml
JQKM4a69Z/583KWFfidF6sCfqlRhnA3Eps/7uDcl1IFlML1fJWe1yw3RtAVlj1NG
KAzVuOJMcL92bkCS1JCG7MUGpWPefeNmSB7QA63IqH6SlfteCP3vh+sRnOCqPy+S
Xs169QKzJB8E/DXdMgB3sFI3e43+ddHs0AOYSjxA7Wqs5Ri6VuEcKgV3FEtNkds=
=H52i
-----END PGP SIGNATURE-----

--wac7ysb48OaltWcw--