From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDDvB-0006Zs-K1 for qemu-devel@nongnu.org; Fri, 01 Aug 2014 10:35:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XDDv1-0001TA-Id for qemu-devel@nongnu.org; Fri, 01 Aug 2014 10:35:01 -0400 Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]:55808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDDv1-0001Sy-Ap for qemu-devel@nongnu.org; Fri, 01 Aug 2014 10:34:51 -0400 Received: by mail-we0-f169.google.com with SMTP id u56so4417650wes.14 for ; Fri, 01 Aug 2014 07:34:50 -0700 (PDT) Date: Fri, 1 Aug 2014 15:34:47 +0100 From: Stefan Hajnoczi Message-ID: <20140801143447.GC11091@stefanha-thinkpad.redhat.com> References: <1404899590-24973-1-git-send-email-pbonzini@redhat.com> <1404899590-24973-2-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/e2eDi0V/xtL+Mc8" Content-Disposition: inline In-Reply-To: <1404899590-24973-2-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 01/10] AioContext: take bottom halves into account when computing aio_poll timeout List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org --/e2eDi0V/xtL+Mc8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 09, 2014 at 11:53:01AM +0200, Paolo Bonzini wrote: > diff --git a/async.c b/async.c > index 34af0b2..ac40eab 100644 > --- a/async.c > +++ b/async.c > @@ -152,39 +152,43 @@ void qemu_bh_delete(QEMUBH *bh) > bh->deleted =3D 1; > } > =20 > -static gboolean > -aio_ctx_prepare(GSource *source, gint *timeout) > +int > +aio_compute_timeout(AioContext *ctx) The return value is now nanoseconds so a 32-bit int doesn't offer much range (only 2 seconds for a signed int). Any reason to use int instead of int64_t as used by the timer API? --/e2eDi0V/xtL+Mc8 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT26WGAAoJEJykq7OBq3PIm/cH/0Xv+3ku704z6akLnVzoO/3g mHxyyD0dGeB//WBgY7YKGpsr8ocdivEL2/CjdAhWP+rMDAYiMA+/jjTFtpIdXwYq BlQ+E9jRbKwenb3xZjugcJQzq6sE0ohXZu9hkdWiUNuJT4Q/px3z/vY/6YDurv9D /ak/h4SEUpEPthju4VSt/dhur89egi/eKWvx/pGy5lSmJL4TbnIe665XUG9Wx/t3 OuW4ukoBDFabz2JT083/+/76Ospf705XL51h6ktyxSEs/sjr26ghjq2VcyhYGy6J AXDuoIgYH3rSrYjOaS+KU94dkGn5TUnkOE3jQxmIoiNiTpSaalJSKUNN53ZpT6w= =YWIg -----END PGP SIGNATURE----- --/e2eDi0V/xtL+Mc8--