From: Erik de Castro Lopo <mle+tools@mega-nerd.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c : Minor cleanups of timer_create handling.
Date: Sun, 3 Aug 2014 08:48:23 +1000 [thread overview]
Message-ID: <20140803084823.0f22dc8512d8ef49ca16fd2c@mega-nerd.com> (raw)
In-Reply-To: <CAFEAcA__nr-5jYudHt53pkb1PwCCCQy+iPCCO4m-kAUdU2A8Vw@mail.gmail.com>
Peter Maydell wrote:
> Doesn't this turn a timer_create(clkid, NULL, phtimer) into a
> timer_create(clkid, something-not-NULL, phtimer) ? That
> doesn't seem right to me (and the code you've deleted here
> is the common idiom in syscall.c for handling those "arg
> is pointer-to-struct-or-NULL" cases).
You're right. Thanks. I will amend this.
Erik
--
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
next prev parent reply other threads:[~2014-08-02 22:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 14:10 [Qemu-devel] [PATCH] linux-user/syscall.c : Minor cleanups of timer_create handling Erik de Castro Lopo
2014-08-02 15:05 ` Peter Maydell
2014-08-02 22:48 ` Erik de Castro Lopo [this message]
2014-08-02 22:50 ` Peter Maydell
2014-08-02 23:21 ` Erik de Castro Lopo
2014-08-02 23:30 ` Peter Maydell
2014-08-02 23:45 ` [Qemu-devel] [PATCH] linux-user: Add missing unlock_user_struct to timer_create Erik de Castro Lopo
2014-08-03 13:09 ` Peter Maydell
2014-08-06 7:47 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140803084823.0f22dc8512d8ef49ca16fd2c@mega-nerd.com \
--to=mle+tools@mega-nerd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).