From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDi6T-0003Yd-79 for qemu-devel@nongnu.org; Sat, 02 Aug 2014 18:48:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XDi6N-0003sr-3J for qemu-devel@nongnu.org; Sat, 02 Aug 2014 18:48:41 -0400 Received: from hendrix.mega-nerd.net ([203.206.230.162]:36562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDi6M-0003rV-Lp for qemu-devel@nongnu.org; Sat, 02 Aug 2014 18:48:35 -0400 Received: from rollins.mnn (pharoah-vpn [10.9.8.2]) by hendrix.mega-nerd.net (Postfix) with SMTP id 5FADF106818 for ; Sun, 3 Aug 2014 08:48:24 +1000 (EST) Date: Sun, 3 Aug 2014 08:48:23 +1000 From: Erik de Castro Lopo Message-Id: <20140803084823.0f22dc8512d8ef49ca16fd2c@mega-nerd.com> In-Reply-To: References: <1406988633-29469-1-git-send-email-erikd@mega-nerd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c : Minor cleanups of timer_create handling. Reply-To: qemu-devel@nongnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Peter Maydell wrote: > Doesn't this turn a timer_create(clkid, NULL, phtimer) into a > timer_create(clkid, something-not-NULL, phtimer) ? That > doesn't seem right to me (and the code you've deleted here > is the common idiom in syscall.c for handling those "arg > is pointer-to-struct-or-NULL" cases). You're right. Thanks. I will amend this. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/