From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDicY-0000HS-Mn for qemu-devel@nongnu.org; Sat, 02 Aug 2014 19:21:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XDicT-0004DH-PD for qemu-devel@nongnu.org; Sat, 02 Aug 2014 19:21:50 -0400 Received: from hendrix.mega-nerd.net ([203.206.230.162]:36597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDicT-0004D2-7f for qemu-devel@nongnu.org; Sat, 02 Aug 2014 19:21:45 -0400 Received: from rollins.mnn (pharoah-vpn [10.9.8.2]) by hendrix.mega-nerd.net (Postfix) with SMTP id 1D608106818 for ; Sun, 3 Aug 2014 09:21:41 +1000 (EST) Date: Sun, 3 Aug 2014 09:21:41 +1000 From: Erik de Castro Lopo Message-Id: <20140803092141.d4d059cfa6be769adc77658b@mega-nerd.com> In-Reply-To: References: <1406988633-29469-1-git-send-email-erikd@mega-nerd.com> <20140803084823.0f22dc8512d8ef49ca16fd2c@mega-nerd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c : Minor cleanups of timer_create handling. Reply-To: qemu-devel@nongnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Peter Maydell wrote: > Amend it to what? The current code looks fine to me, > so I'm not sure what bug you're trying to fix here. There is still a missing call to unlock_user_struct() inside the "if (arg2)" block. Is that not worth fixing? Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/