From: Stefan Hajnoczi <stefanha@redhat.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Fam Zheng <famz@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 10/15] linux-aio: increase max event to 256
Date: Mon, 4 Aug 2014 11:26:39 +0100 [thread overview]
Message-ID: <20140804102639.GD5784@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <CACVXFVMwcpiBs4o+38Hp-=yoxSoTEUucQpTFQaGGw5wGVLs5bg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On Thu, Jul 31, 2014 at 01:20:22AM +0800, Ming Lei wrote:
> On Wed, Jul 30, 2014 at 10:00 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > Il 30/07/2014 13:39, Ming Lei ha scritto:
> >> This patch increases max event to 256 for the comming
> >> virtio-blk multi virtqueue support.
> >>
> >> Signed-off-by: Ming Lei <ming.lei@canonical.com>
> >> ---
> >> block/linux-aio.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > What makes the new magic number less magic than the old one?
>
> Just for supporting the coming multi virtqueue, otherwise it is
> easy to trigger EAGAIN.
>
> Or do you have better idea to figure out a non-magic number?
The virtio-blk device knows how many requests can be in-flight at a
time. laio_init() could take a size parameter. The messy thing is that
the block layer is between the virtio-blk device and Linux AIO, so we'd
need to pass that information down.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-08-04 10:26 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 11:39 [Qemu-devel] [PATCH 00/14] dataplane: optimization and multi virtqueue support Ming Lei
2014-07-30 11:39 ` [Qemu-devel] [PATCH 01/15] qemu coroutine: support bypass mode Ming Lei
2014-07-30 13:45 ` Paolo Bonzini
2014-07-30 17:15 ` Ming Lei
2014-07-30 23:37 ` Paolo Bonzini
2014-07-31 3:55 ` Ming Lei
2014-07-31 7:37 ` Benoît Canet
2014-07-31 9:47 ` Ming Lei
2014-07-31 10:45 ` Paolo Bonzini
2014-08-01 13:38 ` Ming Lei
2014-07-31 8:59 ` Ming Lei
2014-07-31 9:15 ` Paolo Bonzini
2014-07-31 10:06 ` Ming Lei
2014-07-31 16:13 ` Ming Lei
2014-07-31 16:30 ` Paolo Bonzini
2014-08-01 2:54 ` Ming Lei
2014-08-01 13:13 ` Stefan Hajnoczi
2014-08-01 13:48 ` Ming Lei
2014-08-01 14:17 ` Paolo Bonzini
2014-08-01 15:21 ` Ming Lei
2014-08-01 14:52 ` Ming Lei
2014-08-01 16:03 ` Stefan Hajnoczi
2014-08-02 2:42 ` Ming Lei
2014-07-30 11:39 ` [Qemu-devel] [PATCH 02/15] qemu aio: prepare for supporting selective bypass coroutine Ming Lei
2014-07-30 11:39 ` [Qemu-devel] [PATCH 03/15] block: support to bypass qemu coroutinue Ming Lei
2014-07-30 11:39 ` [Qemu-devel] [PATCH 04/15] Revert "raw-posix: drop raw_get_aio_fd() since it is no longer used" Ming Lei
2014-07-30 11:39 ` [Qemu-devel] [PATCH 05/15] dataplane: enable selective bypassing coroutine Ming Lei
2014-07-30 11:39 ` [Qemu-devel] [PATCH 06/15] qemu/obj_pool.h: introduce object allocation pool Ming Lei
2014-07-30 11:39 ` [Qemu-devel] [PATCH 07/15] dataplane: use object pool to speed up allocation for virtio blk request Ming Lei
2014-07-30 14:14 ` Paolo Bonzini
2014-07-30 15:09 ` Michael S. Tsirkin
2014-07-31 3:22 ` Ming Lei
2014-07-31 9:18 ` Paolo Bonzini
2014-08-01 7:42 ` Ming Lei
2014-08-04 10:21 ` Stefan Hajnoczi
2014-08-04 11:42 ` Ming Lei
2014-07-30 11:39 ` [Qemu-devel] [PATCH 08/15] virtio: decrease size of VirtQueueElement Ming Lei
2014-07-30 13:51 ` Paolo Bonzini
2014-07-30 14:40 ` Michael S. Tsirkin
2014-07-30 14:50 ` Paolo Bonzini
2014-07-31 2:11 ` Ming Lei
2014-07-31 2:07 ` Ming Lei
2014-07-31 9:38 ` Paolo Bonzini
2014-08-01 3:34 ` Ming Lei
2014-07-30 11:39 ` [Qemu-devel] [PATCH 09/15] linux-aio: fix submit aio as a batch Ming Lei
2014-07-30 13:59 ` Paolo Bonzini
2014-07-30 17:32 ` Ming Lei
2014-07-30 23:41 ` Paolo Bonzini
2014-07-30 11:39 ` [Qemu-devel] [PATCH 10/15] linux-aio: increase max event to 256 Ming Lei
2014-07-30 12:15 ` Eric Blake
2014-07-30 14:00 ` Paolo Bonzini
2014-07-30 17:20 ` Ming Lei
2014-08-04 10:26 ` Stefan Hajnoczi [this message]
2014-07-30 11:39 ` [Qemu-devel] [PATCH 11/15] linux-aio: remove 'node' from 'struct qemu_laiocb' Ming Lei
2014-07-30 11:39 ` [Qemu-devel] [PATCH 12/15] hw/virtio-pci: introduce num_queues property Ming Lei
2014-07-30 11:39 ` [Qemu-devel] [PATCH 13/15] hw/virtio/virtio-blk.h: introduce VIRTIO_BLK_F_MQ Ming Lei
2014-07-30 11:39 ` [Qemu-devel] [PATCH 14/15] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled Ming Lei
2014-07-30 14:01 ` Paolo Bonzini
2014-07-30 15:12 ` Michael S. Tsirkin
2014-07-30 15:25 ` Paolo Bonzini
2014-07-31 3:47 ` Ming Lei
2014-07-31 8:52 ` Paolo Bonzini
2014-08-01 3:09 ` Ming Lei
2014-08-01 3:24 ` Ming Lei
2014-08-01 6:10 ` Paolo Bonzini
2014-08-01 7:35 ` Ming Lei
2014-08-01 7:46 ` Paolo Bonzini
2014-07-30 11:39 ` [Qemu-devel] [PATCH 15/15] dataplane: virtio-blk: support mutlti virtqueue Ming Lei
2014-07-30 12:42 ` [Qemu-devel] [PATCH 00/14] dataplane: optimization and multi virtqueue support Christian Borntraeger
2014-08-04 10:16 ` Stefan Hajnoczi
2014-08-04 10:45 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804102639.GD5784@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).