qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: kwolf@redhat.com, mst@redhat.com, luonengjun@huawei.com,
	qemu-devel@nongnu.org, lcapitulino@redhat.com, alex@alex.org.uk,
	pbonzini@redhat.com, peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [PATCH 3/4] virtio-blk: fix reference a pointer which might be freed
Date: Mon, 4 Aug 2014 12:14:25 +0100	[thread overview]
Message-ID: <20140804111425.GG5784@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1407140744-11948-4-git-send-email-zhang.zhanghailiang@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

On Mon, Aug 04, 2014 at 04:25:43PM +0800, zhanghailiang wrote:
> In function virtio_blk_handle_request, it may freed memory pointed by req,
> So do not access member of req after calling this function.
> 
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
>  hw/block/virtio-blk.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2014-08-04 11:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04  8:25 [Qemu-devel] [PATCH 0/4] fix several bugs about use-after-free and an api abuse zhanghailiang
2014-08-04  8:25 ` [Qemu-devel] [PATCH 1/4] l2cap: fix access freed memory zhanghailiang
2014-08-04  8:37   ` Alex Bennée
2014-08-04  8:25 ` [Qemu-devel] [PATCH 2/4] monitor: " zhanghailiang
2014-08-04  9:01   ` Alex Bennée
2014-08-05  2:37     ` zhanghailiang
2014-08-04  8:25 ` [Qemu-devel] [PATCH 3/4] virtio-blk: fix reference a pointer which might be freed zhanghailiang
2014-08-04 11:14   ` Stefan Hajnoczi [this message]
2014-08-04  8:25 ` [Qemu-devel] [PATCH 4/4] ivshmem: check the value returned by fstat() zhanghailiang
2014-08-04 12:26   ` Michael S. Tsirkin
2014-08-05  2:00     ` zhanghailiang
2014-08-05  6:50       ` Levente Kurusa
2014-08-05  7:08         ` zhanghailiang
2014-08-05 10:00       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140804111425.GG5784@stefanha-thinkpad.redhat.com \
    --to=stefanha@redhat.com \
    --cc=alex@alex.org.uk \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=luonengjun@huawei.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).