From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47662)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1XEGhr-00040N-Tk
	for qemu-devel@nongnu.org; Mon, 04 Aug 2014 07:45:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1XEGhl-0005Ye-H5
	for qemu-devel@nongnu.org; Mon, 04 Aug 2014 07:45:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19820)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1XEGhl-0005YQ-28
	for qemu-devel@nongnu.org; Mon, 04 Aug 2014 07:45:29 -0400
Date: Mon, 4 Aug 2014 17:15:00 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20140804114500.GP18947@grmbl.mre>
References: <cover.1405510095.git.amit.shah@redhat.com>
	<cover.1405510095.git.amit.shah@redhat.com>
	<c6749c36478b78b14eee4e40918fb0006533f839.1405510095.git.amit.shah@redhat.com>
	<874mxs32vv.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <874mxs32vv.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-serial: create a linked list of
 all active devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Amos Kong <akong@redhat.com>, qemu list <qemu-devel@nongnu.org>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On (Mon) 04 Aug 2014 [13:33:56], Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
> 
> > To ensure two virtserialports don't get added to the system with the
> > same 'name' parameter, we need to access all the ports on all the
> > devices added, and compare the names.
> >
> > We currently don't have a list of all VirtIOSerial devices added to the
> > system.  This commit adds a simple linked list in which devices are put
> > when they're initialized, and removed when they go away.

<snip>

> > +struct VirtIOSerialDevices {
> > +    QLIST_HEAD(, VirtIOSerial) devices;
> > +} vserdevices;
> > +
> 
> Any particular reason for stuffing the list into a struct?

Not strictly needed for this patch alone, but I think it's cleaner to
keep it this way, and when something else comes up that needs a
per-device variable, this list will be around.  Also, this is also the
way it's done in the kernel, so that uniformity helps as well.

<snip>

> Patch looks simple & safe to me, but I can't help to wonder whether want
> (or already have?) more generic infrastructure offering "for all devices
> of a certain kind" functionality, which is what 2/2 needs.  Andreas?

Yea; I didn't find any, but if there's already something it can be put
to good use here.

Thanks,

		Amit