From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEIfM-0000mO-ON for qemu-devel@nongnu.org; Mon, 04 Aug 2014 09:51:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEIfG-0005kH-JW for qemu-devel@nongnu.org; Mon, 04 Aug 2014 09:51:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEIfG-0005kC-A5 for qemu-devel@nongnu.org; Mon, 04 Aug 2014 09:51:02 -0400 Date: Mon, 4 Aug 2014 15:51:18 +0200 From: "Michael S. Tsirkin" Message-ID: <20140804135118.GD17674@redhat.com> References: <1406808574-19728-1-git-send-email-tiejun.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1406808574-19728-1-git-send-email-tiejun.chen@intel.com> Subject: Re: [Qemu-devel] [v3][PATCH 0/5] xen: introduce new machine for IGD passthrough List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tiejun Chen Cc: pbonzini@redhat.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com On Thu, Jul 31, 2014 at 08:09:30PM +0800, Tiejun Chen wrote: > v3: > > * Drop patch #4 > * Add one patch #1 from Michael > * Rebase You added my patch but don't use it, so most of my comment weren't addressed. Do you plan to send v4 to address them? > v2: > > * Fix some coding style > * New patch to separate i440fx_init > * Just add prefix with XEN_IGD_PASSTHROUGH/xen_igd_passthrough > * Based on patch #2 to regenerate > * Unify prefix with XEN_IGD_PASSTHROUGH/xen_igd_passthrough like patch #3 > * Test: boot with a preinstalled ubuntu 14.04 > ./i386-softmmu/qemu-system-i386 -hda test.img -m 2560 -boot c -machine pc > > As we discussed we need to create a separate machine to support current > IGD passthrough. > > ---------------------------------------------------------------- > Tiejun Chen (4): > i440fx: make types configurable at run-time > hw:i386:pc_piix: split pc_init1() > xen:hw:pci-host:piix: create host bridge to passthrough > xen:hw:i386:pc_piix: introduce new machine for IGD passthrough > > hw/i386/pc_piix.c | 227 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------- > hw/pci-host/piix.c | 50 ++++++++++++++++++++++++++++++++++---- > include/hw/i386/pc.h | 8 ++++++- > 3 files changed, 254 insertions(+), 31 deletions(-) > > Thanks > Tiejun