From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35515)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1XEaXV-0008Li-Ky
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 04:56:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1XEaXM-0005WX-JY
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 04:56:13 -0400
Received: from mail-pd0-x229.google.com ([2607:f8b0:400e:c02::229]:58402)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1XEaXM-0005WI-D5
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 04:56:04 -0400
Received: by mail-pd0-f169.google.com with SMTP id y10so990376pdj.0
	for <qemu-devel@nongnu.org>; Tue, 05 Aug 2014 01:56:01 -0700 (PDT)
Date: Tue, 5 Aug 2014 18:53:23 +1000
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20140805085323.GA10292@toto>
References: <1401434911-26992-1-git-send-email-edgar.iglesias@gmail.com>
	<CAFEAcA_bo8NpmTnc5gFAbjv3ksQOMmS7M06zYcPPSayq1qL2Zg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_bo8NpmTnc5gFAbjv3ksQOMmS7M06zYcPPSayq1qL2Zg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v1 00/16] target-arm: Parts of the AArch64
 EL2/3 exception model
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Fabian Aggeler <aggelerf@ethz.ch>, QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, Greg Bellows <greg.bellows@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, Richard Henderson <rth@twiddle.net>

On Fri, Aug 01, 2014 at 03:35:55PM +0100, Peter Maydell wrote:
> On 30 May 2014 08:28, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
> > This is a second round of AArch64 EL2/3 patches working on the exception
> > model. Among other things adding HVC/SMC, interrupt routing to EL2/3 and
> > Virtual IRQs/FIQs. The VIRQ/VFIQ support only adds the external signal
> > delivery method.
> >
> > Patch 3 is a bug fix.
> > Patch 14 fails checkpatch, seems like a bug in checkpatch, CC:d Blue.
> >
> > This conflicts slightly with the PSCI emulation patches that Rob posted.
> > A rebase should be trivial, hooking in the PSCI emulation calls in the
> > HVC/SMC helpers.
> 
> Sorry for letting this patchset sit in my to-review queue for so long.
> Patches 1-6 are good and I'm going to put them in target-arm.next.
> Patches 9 and 11 I've added my R-by to. Patches 7, 8, 10, 12..16
> I've replied to with review comments.

Thanks Peter,

I think I've addressed most of your comments, sending out v4 now.

I fixed up the PC for trapped HVC/SMC and for SMC routed to EL2
but left the exception raising as is. I'm happy to update it if
you have a better idea.

Cheers,
Edgar