From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XEeDJ-0001cX-Ve
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 08:51:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XEeDF-0004Te-CT
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 08:51:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42188)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XEeDF-0004TG-4m
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 08:51:33 -0400
Date: Tue, 5 Aug 2014 14:51:50 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140805125150.GE13367@redhat.com>
References: <1407209598-2572-1-git-send-email-ming.lei@canonical.com>
	<1407209598-2572-2-git-send-email-ming.lei@canonical.com>
	<53E0C645.5050106@redhat.com> <20140805120537.GB13367@redhat.com>
	<53E0CC63.5070602@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53E0CC63.5070602@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1 01/17] qemu/obj_pool.h: introduce object
 allocation pool
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Fam Zheng <famz@redhat.com>, Ming Lei <ming.lei@canonical.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Tue, Aug 05, 2014 at 06:21:55AM -0600, Eric Blake wrote:
> On 08/05/2014 06:05 AM, Michael S. Tsirkin wrote:
> > On Tue, Aug 05, 2014 at 05:55:49AM -0600, Eric Blake wrote:
> >> On 08/04/2014 09:33 PM, Ming Lei wrote:
> >>> This patch introduces object allocation pool for speeding up
> >>> object allocation in fast path.
> >>>
> >>> Signed-off-by: Ming Lei <ming.lei@canonical.com>
> >>> ---
> >>>  include/qemu/obj_pool.h |   64 +++++++++++++++++++++++++++++++++++++++++++++++
> >>>  1 file changed, 64 insertions(+)
> >>>  create mode 100644 include/qemu/obj_pool.h
> >>>
> 
> >>> +
> >>> +    char *objs;
> >>> +} ObjPool;
> >>> +
> >>> +static inline void obj_pool_init(ObjPool *op, void *objs_buf, void **free_objs,
> >>> +                                 unsigned int obj_size, unsigned cnt)
> >>> +{
> >>> +    int i;
> >>> +
> >>> +    op->objs = (char *)objs_buf;
> >>
> >> Why the cast? This is C, not C++.
> > 
> > It's not needed in C++ either, right?
> 
> In C++, going from void* to a typed pointer requires a cast (that's why
> in C++ you see casts on malloc results).

Ah yes, I was confusing this with going from char * to void *.
You are right, thanks for the reminder.

>  In C, void* can implicitly be
> converted to any other pointer (modulo const-/volatile-correctness).

Yes: and const and voilatile safety is exactly the reason
one *shouldn't* typically cast to/from void * explicitly.

> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>