From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45385)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XEfeV-0006v6-HL
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 10:23:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XEfeO-0004gn-0o
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 10:23:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48414)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XEfeN-0004gI-Nt
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 10:23:39 -0400
Date: Tue, 5 Aug 2014 16:23:37 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140805142337.GA13769@redhat.com>
References: <1406014135-1192-1-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1406014135-1192-1-git-send-email-kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci
	sound cards
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Vassili Karpov (malc)" <av1474@comtv.ru>, qemu-devel@nongnu.org

On Tue, Jul 22, 2014 at 09:28:55AM +0200, Gerd Hoffmann wrote:
> This way the tests run without sound hardware being present
> on the build machine.  Even with sound hardware it IMO isn't
> very useful to use it in regression testing.  Once the sound
> card tests are advanced enougth that they try to actually
> play sound we probably want the guests sound output written
> to a file (via QEMU_AUDIO_DRV=wav) rather than played on the
> build machines sound hardware.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Useful already:
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

Long term, won't it be cleaner to supply driver using
a command line flag? Can be a patch on top ...

> ---
>  tests/ac97-test.c      | 3 +++
>  tests/es1370-test.c    | 3 +++
>  tests/intel-hda-test.c | 3 +++
>  3 files changed, 9 insertions(+)
> 
> diff --git a/tests/ac97-test.c b/tests/ac97-test.c
> index af30ea1..ba3be1a 100644
> --- a/tests/ac97-test.c
> +++ b/tests/ac97-test.c
> @@ -8,6 +8,7 @@
>   */
>  
>  #include <glib.h>
> +#include <stdlib.h>
>  #include <string.h>
>  #include "libqtest.h"
>  #include "qemu/osdep.h"
> @@ -21,6 +22,8 @@ int main(int argc, char **argv)
>  {
>      int ret;
>  
> +    setenv("QEMU_AUDIO_DRV", "none", true);
> +
>      g_test_init(&argc, &argv, NULL);
>      qtest_add_func("/ac97/nop", nop);
>  
> diff --git a/tests/es1370-test.c b/tests/es1370-test.c
> index cc23fb5..d539ba3 100644
> --- a/tests/es1370-test.c
> +++ b/tests/es1370-test.c
> @@ -8,6 +8,7 @@
>   */
>  
>  #include <glib.h>
> +#include <stdlib.h>
>  #include <string.h>
>  #include "libqtest.h"
>  #include "qemu/osdep.h"
> @@ -21,6 +22,8 @@ int main(int argc, char **argv)
>  {
>      int ret;
>  
> +    setenv("QEMU_AUDIO_DRV", "none", true);
> +
>      g_test_init(&argc, &argv, NULL);
>      qtest_add_func("/es1370/nop", nop);
>  
> diff --git a/tests/intel-hda-test.c b/tests/intel-hda-test.c
> index d89b407..32dc58f 100644
> --- a/tests/intel-hda-test.c
> +++ b/tests/intel-hda-test.c
> @@ -8,6 +8,7 @@
>   */
>  
>  #include <glib.h>
> +#include <stdlib.h>
>  #include <string.h>
>  #include "libqtest.h"
>  #include "qemu/osdep.h"
> @@ -35,6 +36,8 @@ int main(int argc, char **argv)
>  {
>      int ret;
>  
> +    setenv("QEMU_AUDIO_DRV", "none", true);
> +
>      g_test_init(&argc, &argv, NULL);
>      qtest_add_func("/intel-hda/ich6", ich6_test);
>      qtest_add_func("/intel-hda/ich9", ich9_test);
> -- 
> 1.8.3.1
>