From: Amit Shah <amit.shah@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Amos Kong" <akong@redhat.com>,
"qemu list" <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 0/2] virtio-serial: Prevent addition of ports with same name
Date: Wed, 6 Aug 2014 13:09:44 +0530 [thread overview]
Message-ID: <20140806073944.GB25951@grmbl.mre> (raw)
In-Reply-To: <8738dayt6f.fsf@blackfin.pond.sub.org>
On (Wed) 06 Aug 2014 [09:27:04], Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
>
> > Hi,
> >
> > The 2nd patch prevents adding ports to the system with conflicts in
> > the 'name' parameter. This is done by going through all the ports in
> > the system, including ports on other virtio-serial devices.
> >
> > The first patch prepares for this by creating a linked list of all
> > available virtio-serial devices, so they can be walked over to check
> > their ports' names.
> >
> > Please review.
>
> No advice from Andreas on better ways to iterate over devices, yet
> (vacation time?). If there is one, we can always use it on top.
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Thanks!
I'll wait for a week before submitting a pull req.
Amit
next prev parent reply other threads:[~2014-08-06 7:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 11:31 [Qemu-devel] [PATCH 0/2] virtio-serial: Prevent addition of ports with same name Amit Shah
2014-07-16 11:31 ` [Qemu-devel] [PATCH 1/2] virtio-serial: create a linked list of all active devices Amit Shah
2014-08-04 11:33 ` Markus Armbruster
2014-08-04 11:45 ` Amit Shah
2014-08-06 7:27 ` Markus Armbruster
2014-08-06 7:39 ` Amit Shah
2014-08-18 17:21 ` Andreas Färber
2014-08-19 15:45 ` Markus Armbruster
2014-08-19 16:15 ` Andreas Färber
2014-07-16 11:31 ` [Qemu-devel] [PATCH 2/2] virtio-serial: search for duplicate port names before adding new ports Amit Shah
2014-08-06 7:27 ` [Qemu-devel] [PATCH 0/2] virtio-serial: Prevent addition of ports with same name Markus Armbruster
2014-08-06 7:39 ` Amit Shah [this message]
2014-08-18 17:10 ` Amit Shah
2014-08-18 17:17 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806073944.GB25951@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=afaerber@suse.de \
--cc=akong@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).