From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52470)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1XEvpd-0005IM-E8
	for qemu-devel@nongnu.org; Wed, 06 Aug 2014 03:40:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1XEvpX-0004my-44
	for qemu-devel@nongnu.org; Wed, 06 Aug 2014 03:40:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54681)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1XEvpW-0004mq-T7
	for qemu-devel@nongnu.org; Wed, 06 Aug 2014 03:40:15 -0400
Date: Wed, 6 Aug 2014 13:09:44 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20140806073944.GB25951@grmbl.mre>
References: <cover.1405510095.git.amit.shah@redhat.com>
	<8738dayt6f.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8738dayt6f.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH 0/2] virtio-serial: Prevent addition of
 ports with same name
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Amos Kong <akong@redhat.com>, qemu list <qemu-devel@nongnu.org>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On (Wed) 06 Aug 2014 [09:27:04], Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
> 
> > Hi,
> >
> > The 2nd patch prevents adding ports to the system with conflicts in
> > the 'name' parameter.  This is done by going through all the ports in
> > the system, including ports on other virtio-serial devices.
> >
> > The first patch prepares for this by creating a linked list of all
> > available virtio-serial devices, so they can be walked over to check
> > their ports' names.
> >
> > Please review.
> 
> No advice from Andreas on better ways to iterate over devices, yet
> (vacation time?).  If there is one, we can always use it on top.
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

Thanks!

I'll wait for a week before submitting a pull req.


		Amit