From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XExku-0005co-Vr for qemu-devel@nongnu.org; Wed, 06 Aug 2014 05:43:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XExko-0004Y9-Md for qemu-devel@nongnu.org; Wed, 06 Aug 2014 05:43:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XExko-0004Xz-G8 for qemu-devel@nongnu.org; Wed, 06 Aug 2014 05:43:30 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s769hTYv012336 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 6 Aug 2014 05:43:30 -0400 Date: Wed, 6 Aug 2014 10:43:27 +0100 From: Stefan Hajnoczi Message-ID: <20140806094327.GB17426@stefanha-thinkpad.redhat.com> References: <1407186691-16103-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dc+cDN39EJAMEtIO" Content-Disposition: inline In-Reply-To: <1407186691-16103-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 00/30] AHCI test suite framework List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com --dc+cDN39EJAMEtIO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 04, 2014 at 05:11:01PM -0400, John Snow wrote: > This patch series introduces a number of small fixes and tweaks to > help support an AHCI test suite that in the future I hope to expand > to a fuller regression suite to help guide the development of the > AHCI device support under, in particular, the Q35 machine type in QEMU. >=20 > Paolo Bonzini has contributed a number of cleanup and refactoring patches > that support changes to the PIO setup FIS packet construction code, which > is necessary for testing ths specification adherence of the IDENTIFY comm= and, > which issues its data exclusively via PIO mechanisms. >=20 > The ahci-test code being checked in represents a minimum of functionality > needed in order to issue and receive commands from the AHCI HBA under the > libqos / qtest environment. >=20 > In V2, as detailed below, these tests are not currently expected to pass. > I will post a complementary patch outside of this set that highlights > the exact set of tests that will not pass, which can help verify at least > the portions of these tests that do work correctly. >=20 > Assertions that currently fail: > - Ordering of PCI capabilities as defined by either AHCI or Intel ICH9 > - Boot-time values of the PxTFD register, which should not have valid > data until after a D2H FIS is received, but does in Qemu 2.1 > - Boot-time values of the PxSIG register, which should have a specific > placeholder signature until the first D2H FIS is received, but is > currently blank. > - The "Descriptor Processed" interrupt is expected after the IDENTIFY > command exhausts the given PRDT, but is not seen. I guess these are the assertion failures: ERROR:tests/ahci-test.c:777:ahci_test_pci_spec: assertion failed ((data & 0= xFF) =3D=3D PCI_CAP_ID_MSI): (0x00000012 =3D=3D 0x00000005) GTester: last random seed: R02Sd92815a5d013e8433808b903b2b13fb0 ** ERROR:tests/ahci-test.c:1165:ahci_test_port_spec: assertion failed ((reg) &= ((0x01)) =3D=3D ((0x01))): (0x00000000 =3D=3D 0x00000001) GTester: last random seed: R02S4d6c05e864dc777e64141cdc6d2a18cf ** ERROR:tests/ahci-test.c:1360:ahci_test_identify: assertion failed ((reg) & = ((0x20)) =3D=3D ((0x20))): (0x00000000 =3D=3D 0x00000020) GTester: last random seed: R02S2b3b330b83a66badb24da80b48120b1d Why publish this patch series if the test fails? We can't merge failing tests. --dc+cDN39EJAMEtIO Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT4fi/AAoJEJykq7OBq3PImzoH/0cwgI3RQn6SOKO2zHZ/2+1A rH8Wu19jUNo6qVcNXFPyQ88KpNk5eATFhwN0uFzA3yzIi2ldw2uKOLPLpKBdUxSw xkzYFfjvpXIMuMLj8KL3LO5LGgE//4wX3NLIk+qbrk8UsaGvtq0PzKkfFqgAW/Gc Ib4IC/ytFipaJ2oiRPY7mSVD4wF51XstcHeoqb5mPYeRhhdpKkp1r2hOVarxpifB U9b8RJrv+jLFdzvURSUuC2fbZTlWkUImLLav4HqKl/52nA2nu2C8M2SrcWQ7RjrU 5dzOGEBWlOOa0GKtO0jxUyB8UYQSCdXyjXSbIT4Qj5OeWvxqFG6M4B1t5OONNyI= =M7LD -----END PGP SIGNATURE----- --dc+cDN39EJAMEtIO--