From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56932)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1XFDNQ-0007KC-Fl
	for qemu-devel@nongnu.org; Wed, 06 Aug 2014 22:24:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1XFDNK-0001Ga-AP
	for qemu-devel@nongnu.org; Wed, 06 Aug 2014 22:24:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18864)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1XFDNK-0001GU-3D
	for qemu-devel@nongnu.org; Wed, 06 Aug 2014 22:24:18 -0400
Date: Thu, 7 Aug 2014 10:24:12 +0800
From: Amos Kong <akong@redhat.com>
Message-ID: <20140807022412.GB8109@z.redhat.com>
References: <1407349101-27793-1-git-send-email-ehabkost@redhat.com>
	<1407349101-27793-2-git-send-email-ehabkost@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1407349101-27793-2-git-send-email-ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RESEND 1/2] rng-egd: Free old chr_name
 value before setting new one
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Markus Armbruster <armbru@redhat.com>

On Wed, Aug 06, 2014 at 03:18:20PM -0300, Eduardo Habkost wrote:
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  backends/rng-egd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/backends/rng-egd.c b/backends/rng-egd.c
> index 25bb3b4..2962795 100644
> --- a/backends/rng-egd.c
> +++ b/backends/rng-egd.c
> @@ -169,6 +169,7 @@ static void rng_egd_set_chardev(Object *obj, const char *value, Error **errp)
>      if (b->opened) {
>          error_set(errp, QERR_PERMISSION_DENIED);
>      } else {
> +        g_free(s->chr_name);
>          s->chr_name = g_strdup(value);
>      }
>  }

Eduardo, a similar patch had been applied.

commit 5e490b6a504912225dff0e520e1c6af68295d238
Author: Amos Kong <akong@redhat.com>
Date:   Thu Nov 21 16:42:50 2013 +0800

    rng-egd: remove redundant free
    
    We didn't set default chr_name, the free is redundant.
    
    Signed-off-by: Amos Kong <akong@redhat.com>
    Message-id: 1385023371-8198-2-git-send-email-akong@redhat.com
    Signed-off-by: Anthony Liguori <aliguori@amazon.com>

> -- 
> 1.9.3

-- 
			Amos.