From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFQBI-00029h-8R for qemu-devel@nongnu.org; Thu, 07 Aug 2014 12:04:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFQB4-0003Z6-Rg for qemu-devel@nongnu.org; Thu, 07 Aug 2014 12:04:44 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:36500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFQB4-0003Yj-KF for qemu-devel@nongnu.org; Thu, 07 Aug 2014 12:04:30 -0400 Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Aug 2014 10:04:29 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <53E3A051.6030707@redhat.com> References: <1407357598-21541-1-git-send-email-mdroth@linux.vnet.ibm.com> <53E2A2FE.1060401@redhat.com> <20140807091908.6230.28961@loki> <53E3A051.6030707@redhat.com> Message-ID: <20140807160423.6230.42402@loki> Date: Thu, 07 Aug 2014 11:04:23 -0500 Subject: Re: [Qemu-devel] [000/108] Patch Round-up for stable 2.0.1, freeze on 2014-08-12 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org Quoting Eric Blake (2014-08-07 10:50:41) > On 08/07/2014 03:19 AM, Michael Roth wrote: > >> > >> Libvirt could support active commit against qemu 2.0.1 if you backport > >> these patches: > >> > >> Jeff Cody > >> 7676e2c597 block: make 'top' argument to block-commit optional > >> > >> Fam Zheng > >> 9e48b02540 mirror: Go through ready -> complete process for 0 len im= age > > = > > Actually ended up needing the following with a few fix-ups: > > = > > 7676e2c->98103fa block: make 'top' argument to block-commit optional > > 8b9a30c->e5f0eb0 qemu-iotests: Test BLOCK_JOB_READY event for 0Kb image= active commit > > 9e48b02->43ac708 mirror: Go through ready -> complete process for 0 len= image > > dc71ce4->8e09e20 blockjob: Add block_job_yield() > > 373df5b->520b341 mirror: Fix resource leak when bdrv_getlength fails > > = > > I've gone ahead and pushed them, but please test as we generally don't > > do features (even backward-compatible ones) for stable, and this wasn't > > as trivial as I was hoping. > = > Yes, I'll test and report back. However, I don't think this is a Thanks! > Yes, I'll test and report back. However, I don't think this is a > feature addition, so much as a bug fix for an existing feature (all the > hard work for active commit was already in 2.0, all that was missing was > a way for libvirt to introspect that it existed, and some corner case > bugs with 0-length images). Well, I think it would be hard to draw the line if you start getting into things like new command-line options and such, but the distinction does seem reasonable in this case. > = > -- = > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org