From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFfSa-0004nI-Tl for qemu-devel@nongnu.org; Fri, 08 Aug 2014 04:23:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFfSU-00018E-Ou for qemu-devel@nongnu.org; Fri, 08 Aug 2014 04:23:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFfSU-00017u-Gx for qemu-devel@nongnu.org; Fri, 08 Aug 2014 04:23:30 -0400 Date: Fri, 8 Aug 2014 10:23:23 +0200 From: Kevin Wolf Message-ID: <20140808082323.GB4118@noname.redhat.com> References: <1403624224-2084-1-git-send-email-kwolf@redhat.com> <53E3C6B3.5030300@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <53E3C6B3.5030300@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 00/21] block: Handle failure for potentially large allocations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: benoit.canet@irqsave.net, maxa@catit.be, qemu-devel@nongnu.org, stefanha@redhat.com Am 07.08.2014 um 20:34 hat Max Reitz geschrieben: > On 24.06.2014 17:36, Kevin Wolf wrote: > >A not too small part of the recent CVEs were DoS scenarios by letting > >qemu abort with too large memory allocations. We generally "fixed" the= se > >cases by setting some limits on values read from image files that > >influence the size of allocations. > > > >Because we still need to allow reading large images, this works only t= o > >a certain degree and we still can get fairly large allocations, which > >are not unthinkable to fail on some machines. > > > >This series converts potentially large allocations to g_try_malloc() a= nd > >friends and handles failure gracefully e.g. by returning -ENOMEM. This > >may cause hot-plug of a new disk or individual requests to fail, but t= he > >VM as a whole can keep running. >=20 > Ping =E2=80=93 is there anything missing here? This series does contain= one > patch from me, so I'm naturally interested in seeing this series > getting merged. ;-) Whoops, thanks for the reminder. I completely forgot about this series. Applied it to the block branch now. Kevin