From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFgCs-0006GH-HU for qemu-devel@nongnu.org; Fri, 08 Aug 2014 05:11:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFgCj-0001MC-LH for qemu-devel@nongnu.org; Fri, 08 Aug 2014 05:11:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14349) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFgCj-0001M8-Ej for qemu-devel@nongnu.org; Fri, 08 Aug 2014 05:11:17 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s789BGe5012935 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 8 Aug 2014 05:11:16 -0400 Date: Fri, 8 Aug 2014 11:11:14 +0200 From: Kevin Wolf Message-ID: <20140808091114.GD4118@noname.redhat.com> References: <1407444475-19516-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1407444475-19516-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/3] qcow2: Prevent corruption-related crashes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Am 07.08.2014 um 22:47 hat Max Reitz geschrieben: > The first two patches in this series address > https://bugs.launchpad.net/qemu/+bug/1349972. > > For the third patch I found it hard to write an appropriate test case > (it would have to make qemu-img check repair some leaks but induce the > corruption prevention at the same time). One can use the test image from > the bug report above, set the refcount block offset to 0 and that works. > However, the patch is simple enough that no test should be necessary. Thanks, applied all to the block branch. Kevin