From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45825)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XFk4l-0005S0-KD
	for qemu-devel@nongnu.org; Fri, 08 Aug 2014 09:19:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XFk4c-0003Jn-2V
	for qemu-devel@nongnu.org; Fri, 08 Aug 2014 09:19:19 -0400
Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:40236)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XFk4b-0003Jj-Rr
	for qemu-devel@nongnu.org; Fri, 08 Aug 2014 09:19:09 -0400
Received: by mail-wg0-f48.google.com with SMTP id x13so5632140wgg.7
	for <qemu-devel@nongnu.org>; Fri, 08 Aug 2014 06:19:09 -0700 (PDT)
Date: Fri, 8 Aug 2014 14:19:05 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140808131905.GH15209@stefanha-thinkpad.redhat.com>
References: <20140806145722.7272.62350.malonedeb@chaenomeles.canonical.com>
	<20140806153231.7448.49355.launchpad@chaenomeles.canonical.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ISKrrfpKsPiF35CV"
Content-Disposition: inline
In-Reply-To: <20140806153231.7448.49355.launchpad@chaenomeles.canonical.com>
Subject: Re: [Qemu-devel] [Bug 1353545] Re: QED does not deliver flush on
 synchronized write
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bug 1353545 <1353545@bugs.launchpad.net>
Cc: qemu-devel@nongnu.org


--ISKrrfpKsPiF35CV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 06, 2014 at 03:32:29PM -0000, Nybble wrote:
> ** Changed in: qemu
>        Status: New => Invalid

I guess you saw that bdrv_co_flush() calls bdrv_co_flush(bs->file).
This means that even block drivers that do not provide
->bdrv_co_flush_to_disk() will have fdatasync() called on their image
file.

Stefan

--ISKrrfpKsPiF35CV
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJT5M5JAAoJEJykq7OBq3PI+s0H/3bFUzLgqUgsEWobe8RU9uKQ
IROboQk44n/1KvA7PSir+XlemvRtpH+eAIkrn9G0vw/Qgr9lXdFCO+RGRlvxYWw3
v+uhPSV5XnvcIimMCcrom1Xl9yAf8YsjKgyw68uD/qr7wbXcdbOg0OdmpCT2xC2t
XQJwnX5zw91BHRQeVFMWJbAOp9q/Kok2+kK2JktaalE30H1SRiE7md+v3sWbSw0U
4sui80rVgj3ZQWzcftfgvLfJsNvL+dMgY0NNHj7QMWsF6AwTWbxXJzGjIjaGqxoU
WV28jVIL8ab10sDfy3mnLJge9cp5KNWpSP8nFctc5yM1oBxJhKQpsnSTspswCII=
=w8Zt
-----END PGP SIGNATURE-----

--ISKrrfpKsPiF35CV--