qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 1/2] block: Pass errp in blkconf_geometry
Date: Mon, 11 Aug 2014 15:24:15 +0100	[thread overview]
Message-ID: <20140811142415.GB496@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1407746718-16527-2-git-send-email-famz@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

On Mon, Aug 11, 2014 at 04:45:17PM +0800, Fam Zheng wrote:
> This allows us to pass error information to caller.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  hw/block/block.c         | 18 +++++++++---------
>  hw/block/virtio-blk.c    |  7 +++----
>  hw/ide/qdev.c            | 11 ++++++++---
>  hw/scsi/scsi-disk.c      | 11 ++++++++---
>  include/hw/block/block.h |  6 ++++--
>  5 files changed, 32 insertions(+), 21 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

  parent reply	other threads:[~2014-08-11 14:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11  8:45 [Qemu-devel] [PATCH v3 0/2] scsi: Change device init to realize Fam Zheng
2014-08-11  8:45 ` [Qemu-devel] [PATCH v3 1/2] block: Pass errp in blkconf_geometry Fam Zheng
2014-08-11 11:20   ` Andreas Färber
2014-08-11 14:24   ` Stefan Hajnoczi [this message]
2014-08-11  8:45 ` [Qemu-devel] [PATCH v3 2/2] scsi-bus: Convert DeviceClass init to realize Fam Zheng
2014-08-11 14:32   ` Stefan Hajnoczi
2014-08-12  2:04     ` Fam Zheng
2014-08-12  8:59       ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140811142415.GB496@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=armbru@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).