From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XH7qH-0002lL-6a for qemu-devel@nongnu.org; Tue, 12 Aug 2014 04:54:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XH7qC-0004cz-Ow for qemu-devel@nongnu.org; Tue, 12 Aug 2014 04:54:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XH7qC-0004ct-G6 for qemu-devel@nongnu.org; Tue, 12 Aug 2014 04:54:00 -0400 Date: Tue, 12 Aug 2014 09:53:43 +0100 From: Stefan Hajnoczi Message-ID: <20140812085343.GA20490@stefanha-thinkpad.redhat.com> References: <1407515016-26273-1-git-send-email-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC" Content-Disposition: inline In-Reply-To: <1407515016-26273-1-git-send-email-mark.cave-ayland@ilande.co.uk> Subject: Re: [Qemu-devel] [PATCH 0/5] cmd646 tidy-up and interrupt status fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: kwolf@redhat.com, qemu-devel@nongnu.org --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 08, 2014 at 05:23:31PM +0100, Mark Cave-Ayland wrote: > This patchset came out of my work trying to boot NetBSD on SPARC64. >=20 > According to the datasheet, the 646U2 UDMA interrupt status bits are exac= t=20 > mirrors of the normal DMA interrupt status bits, and an interrupt can be > cleared by writing a 1 to the relevant bit in PCI configuration space. >=20 > The existing implementation caused NetBSD to fail since it would always c= heck > and clear the normal DMA interrupt status bit, even if UDMA was being use= d. > Hence this patchset ensures that the current interrupt status is always= =20 > consistent between both normal DMA and UDMA registers, including when eit= her=20 > one of the interrupt status bits is cleared by writing to PCI configurati= on=20 > space. >=20 > Signed-off-by: Mark Cave-Ayland >=20 > Mark Cave-Ayland (5): > cmd646: add constants for CNTRL register access > cmd646: synchronise DMA interrupt status with UDMA interrupt status > cmd646: switch cmd646_update_irq() to accept PCIDevice instead of > PCIIDEState > cmd646: allow MRDMODE interrupt status bits clearing from PCI config > space > cmd646: synchronise UDMA interrupt status with DMA interrupt status >=20 > hw/ide/cmd646.c | 94 +++++++++++++++++++++++++++++++++++++++++++++++++= ------ > 1 file changed, 85 insertions(+), 9 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT6dYXAAoJEJykq7OBq3PIpLcH/i10p1O1Nh930tJR4yEJJsLO ylJyz4UnJC/25mb4PXH0oXCSplozDGZxDQi5VnO1Y3uSmiIT7sA9ndhAoIsuiAqF DbgQLNibhDBq/fo1zOApdpt8kUlVzD819ac1ya5M2qhBWEdZc2Phb/fn0EkfTv4a YeG4a00BKIDFamNmXlRn2t3mXH5/zZG555wjSX5+fG7mG7u/3Nnur79KZvpHeyNc AHkxzlqXnK3wz1XrtVu5RkSbqHrGLE+xH2CN98K3GqmHJowPHf/Nn5b0xv+9kWKw 5EdJwefmYkQgT1xko7mh3U+2N9TGX3IKln9LPQXea0uzasppUTmbsNQS2llOk48= =4CTL -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC--