From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHbni-0003FY-8T for qemu-devel@nongnu.org; Wed, 13 Aug 2014 12:53:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHbnW-0004nN-Fk for qemu-devel@nongnu.org; Wed, 13 Aug 2014 12:53:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHbnW-0004nH-8e for qemu-devel@nongnu.org; Wed, 13 Aug 2014 12:53:14 -0400 Date: Wed, 13 Aug 2014 17:52:00 +0100 From: Stefan Hajnoczi Message-ID: <20140813165200.GD27053@stefanha-thinkpad.redhat.com> References: <1407843716-18301-1-git-send-email-marc.mari.barcelo@gmail.com> <1407843716-18301-3-git-send-email-marc.mari.barcelo@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wLAMOaPNJ0fu1fTG" Content-Disposition: inline In-Reply-To: <1407843716-18301-3-git-send-email-marc.mari.barcelo@gmail.com> Subject: Re: [Qemu-devel] [PATCH v4 02/11] tests: Add virtio device initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marc =?iso-8859-1?Q?Mar=ED?= Cc: Paolo Bonzini , qemu-devel@nongnu.org --wLAMOaPNJ0fu1fTG Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 12, 2014 at 01:41:47PM +0200, Marc Mar=ED wrote: > +static uint64_t qvirtio_pci_config_readq(QVirtioDevice *d, void *addr) > +{ > + QVirtioPCIDevice *dev =3D (QVirtioPCIDevice *)d; > + return qpci_io_readl(dev->pdev, addr) | qpci_io_readl(dev->pdev, add= r+4); This is broken because it never shifts bits into the upper 32 bits. Which value to shift up depends on endianness. Another solution is to do byte reads into a uint64_t variable like memcpy. I suggest you simply drop 64-bit accesses for now since they are probably not used. --wLAMOaPNJ0fu1fTG Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT65ewAAoJEJykq7OBq3PIV0MIALMhayScbW+AfQpAh75NBoJ0 twEt3v1u7hfnAn3fD2iskYXSss/GkXa40XoInxAhGwQ7tVr9ru4VP24TJ+dBVyq3 CVB2nP2b4s4MMRsO0/GrmuDuFnAjBKJYgIEnxuXbIEroeJeCFXFiknyBUP3fES56 J7ZnJlwFqBxWELJS9h2fLTL6SQO0SvnxFWSMbf+XyT3oNc2lX0t93o37ua7+cGeY CItpo6c6FELaFEtd7YL9VA6aCOQpljZcue2eL+0VIsQbPKPgQVV42KXWPD03jACN 1FdifQv2Zq575C9UqFqoL6oRfMv2n8cNWru4mdtw+UTxsgLKDoG82LqbwnuVkRo= =wD6N -----END PGP SIGNATURE----- --wLAMOaPNJ0fu1fTG--