From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHs4k-0006Q3-EM for qemu-devel@nongnu.org; Thu, 14 Aug 2014 06:16:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHs4g-0003eR-4P for qemu-devel@nongnu.org; Thu, 14 Aug 2014 06:16:06 -0400 Date: Thu, 14 Aug 2014 12:15:57 +0200 From: "Michael S. Tsirkin" Message-ID: <20140814101557.GB31346@redhat.com> References: <1408001361-13580-1-git-send-email-zhang.zhanghailiang@huawei.com> <1408001361-13580-6-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1408001361-13580-6-git-send-email-zhang.zhanghailiang@huawei.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 05/10] util/path: Use the GLib memory allocation routines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: kwolf@redhat.com, lkurusa@redhat.com, qemu-trivial@nongnu.org, jan.kiszka@siemens.com, riku.voipio@iki.fi, mjt@tls.msk.ru, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@redhat.com, luonengjun@huawei.com, pbonzini@redhat.com, peter.huangpeng@huawei.com, alex.bennee@linaro.org, rth@twiddle.net On Thu, Aug 14, 2014 at 03:29:16PM +0800, zhanghailiang wrote: > In this file, we don't check the return value of malloc/strdup/realloc = which may fail. > Instead of using these routines, we use the GLib memory APIs g_malloc/g= _strdup/g_realloc. > They will exit on allocation failure, so there is no need to test for f= ailure, > which would be fine for setup. >=20 > Signed-off-by: zhanghailiang > Reviewed-by: Alex Benn=E9e > --- > util/path.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/util/path.c b/util/path.c > index 5c59d9f..e152f2a 100644 > --- a/util/path.c > +++ b/util/path.c > @@ -45,8 +45,8 @@ static struct pathelem *new_entry(const char *root, > struct pathelem *parent, > const char *name) > { > - struct pathelem *new =3D malloc(sizeof(*new)); > - new->name =3D strdup(name); > + struct pathelem *new =3D g_malloc(sizeof(*new)); > + new->name =3D g_strdup(name); > new->pathname =3D g_strdup_printf("%s/%s", root, name); > new->num_entries =3D 0; > return new; Would not we have to free name using g_free as well? > @@ -88,7 +88,7 @@ static struct pathelem *add_entry(struct pathelem *ro= ot, const char *name, > =20 > root->num_entries++; > =20 > - root =3D realloc(root, sizeof(*root) > + root =3D g_realloc(root, sizeof(*root) > + sizeof(root->entries[0])*root->num_entries); > e =3D &root->entries[root->num_entries-1]; > --=20 > 1.7.12.4 >=20