From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Stefan Weil <sw@weilnetz.de>, Knut Omang <knut.omang@oracle.com>,
Le Tan <tamlokveer@gmail.com>,
qemu-devel@nongnu.org,
Alex Williamson <alex.williamson@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables
Date: Thu, 14 Aug 2014 13:44:34 +0200 [thread overview]
Message-ID: <20140814114434.GA24166@redhat.com> (raw)
In-Reply-To: <53EC9F51.7050304@web.de>
On Thu, Aug 14, 2014 at 01:36:49PM +0200, Jan Kiszka wrote:
> On 2014-08-14 13:06, Michael S. Tsirkin wrote:
> > On Mon, Aug 11, 2014 at 03:05:00PM +0800, Le Tan wrote:
> >> Expose Intel IOMMU to the BIOS. If object of TYPE_INTEL_IOMMU_DEVICE exists,
> >> add DMAR table to ACPI RSDT table. For now the DMAR table indicates that there
> >> is only one hardware unit without INTR_REMAP capability on the platform.
> >>
> >> Signed-off-by: Le Tan <tamlokveer@gmail.com>
> >
> > Could you add a unit test please?
>
> While unit tests would really be helpful, I'm afraid that's not in reach
> (GSoC is almost over).
How much time is left BTW?
> The good news is that we have pretty broad test
> coverage with both Linux and also Jailhouse already.
>
> Do you see unit tests as precondition for merging the series?
>
> Jan
>
>
next prev parent reply other threads:[~2014-08-14 11:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 7:04 [Qemu-devel] [PATCH v3 0/5] intel-iommu: introduce Intel IOMMU (VT-d) emulation to q35 chipset Le Tan
2014-08-11 7:04 ` [Qemu-devel] [PATCH v3 1/5] iommu: add is_write as a parameter to the translate function of MemoryRegionIOMMUOps Le Tan
2014-08-11 7:04 ` [Qemu-devel] [PATCH v3 2/5] intel-iommu: introduce Intel IOMMU (VT-d) emulation Le Tan
2014-08-12 7:34 ` Jan Kiszka
2014-08-12 9:04 ` Le Tan
2014-08-14 11:03 ` Michael S. Tsirkin
2014-08-11 7:05 ` [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables Le Tan
2014-08-14 11:06 ` Michael S. Tsirkin
2014-08-14 11:36 ` Jan Kiszka
2014-08-14 11:43 ` Michael S. Tsirkin
2014-08-14 11:51 ` Jan Kiszka
2014-08-14 11:53 ` Le Tan
2014-08-14 12:04 ` Michael S. Tsirkin
2014-08-14 11:44 ` Michael S. Tsirkin [this message]
2014-08-14 11:37 ` Le Tan
2014-08-11 7:05 ` [Qemu-devel] [PATCH v3 4/5] intel-iommu: add Intel IOMMU emulation to q35 and add a machine option "iommu" as a switch Le Tan
2014-08-14 11:12 ` Michael S. Tsirkin
2014-08-14 11:33 ` Le Tan
2014-08-14 11:35 ` Michael S. Tsirkin
2014-08-14 11:39 ` Le Tan
2014-08-11 7:05 ` [Qemu-devel] [PATCH v3 5/5] intel-iommu: add supports for queued invalidation interface Le Tan
2014-08-14 11:15 ` [Qemu-devel] [PATCH v3 0/5] intel-iommu: introduce Intel IOMMU (VT-d) emulation to q35 chipset Michael S. Tsirkin
2014-08-14 12:10 ` Jan Kiszka
2014-08-15 4:42 ` Knut Omang
2014-08-15 11:15 ` Knut Omang
2014-08-15 11:37 ` Le Tan
2014-08-16 7:54 ` Knut Omang
2014-08-16 8:45 ` Jan Kiszka
2014-08-16 8:47 ` Jan Kiszka
2014-08-18 16:34 ` Knut Omang
2014-08-18 18:50 ` Jan Kiszka
2014-08-19 4:08 ` Knut Omang
2014-08-19 4:18 ` Knut Omang
2014-08-19 5:36 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814114434.GA24166@redhat.com \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=aliguori@amazon.com \
--cc=jan.kiszka@web.de \
--cc=knut.omang@oracle.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=tamlokveer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).