From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60557)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XHtRx-0002CK-P0
	for qemu-devel@nongnu.org; Thu, 14 Aug 2014 07:44:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XHtRr-0007fV-Jx
	for qemu-devel@nongnu.org; Thu, 14 Aug 2014 07:44:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17500)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XHtRr-0007fR-CC
	for qemu-devel@nongnu.org; Thu, 14 Aug 2014 07:44:03 -0400
Date: Thu, 14 Aug 2014 13:44:34 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140814114434.GA24166@redhat.com>
References: <1407740702-4086-1-git-send-email-tamlokveer@gmail.com>
	<1407740702-4086-4-git-send-email-tamlokveer@gmail.com>
	<20140814110652.GQ31346@redhat.com> <53EC9F51.7050304@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53EC9F51.7050304@web.de>
Subject: Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI
	tables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Stefan Weil <sw@weilnetz.de>, Knut Omang <knut.omang@oracle.com>, Le Tan <tamlokveer@gmail.com>, qemu-devel@nongnu.org, Alex Williamson <alex.williamson@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Paolo Bonzini <pbonzini@redhat.com>

On Thu, Aug 14, 2014 at 01:36:49PM +0200, Jan Kiszka wrote:
> On 2014-08-14 13:06, Michael S. Tsirkin wrote:
> > On Mon, Aug 11, 2014 at 03:05:00PM +0800, Le Tan wrote:
> >> Expose Intel IOMMU to the BIOS. If object of TYPE_INTEL_IOMMU_DEVICE exists,
> >> add DMAR table to ACPI RSDT table. For now the DMAR table indicates that there
> >> is only one hardware unit without INTR_REMAP capability on the platform.
> >>
> >> Signed-off-by: Le Tan <tamlokveer@gmail.com>
> > 
> > Could you add a unit test please?
> 
> While unit tests would really be helpful, I'm afraid that's not in reach
> (GSoC is almost over).

How much time is left BTW?

> The good news is that we have pretty broad test
> coverage with both Linux and also Jailhouse already.
> 
> Do you see unit tests as precondition for merging the series?
> 
> Jan
> 
>