From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHxXU-00023W-J3 for qemu-devel@nongnu.org; Thu, 14 Aug 2014 12:06:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHxXO-00015K-DW for qemu-devel@nongnu.org; Thu, 14 Aug 2014 12:06:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHxXO-000156-5D for qemu-devel@nongnu.org; Thu, 14 Aug 2014 12:06:02 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7EG61M5009465 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 14 Aug 2014 12:06:01 -0400 Date: Thu, 14 Aug 2014 17:05:59 +0100 From: Stefan Hajnoczi Message-ID: <20140814160559.GD24132@stefanha-thinkpad.redhat.com> References: <1407966975-3723-1-git-send-email-jsnow@redhat.com> <1407966975-3723-5-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oj4kGyHlBMXGt3Le" Content-Disposition: inline In-Reply-To: <1407966975-3723-5-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 28/32] ahci: add test_pci_enable to ahci-test. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com --oj4kGyHlBMXGt3Le Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 13, 2014 at 05:56:11PM -0400, John Snow wrote: > diff --git a/tests/ahci-test.c b/tests/ahci-test.c > index 29ac0d0..0ca4a20 100644 > --- a/tests/ahci-test.c > +++ b/tests/ahci-test.c > @@ -56,6 +56,7 @@ > /*** Globals ***/ > static QGuestAllocator *guest_malloc; > static QPCIBus *pcibus; > +static uint64_t barsize; This variable is not used so it would be nicer to move it to the relevant later patch. --oj4kGyHlBMXGt3Le Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT7N5nAAoJEJykq7OBq3PI+yoIAKmQSK0IqViNqgQwHVJHChR+ oI0t7UzfqL592RO+AQ+lCvXuqwBrdmcZGVxxflJeLtrk+OgNoWyxwa8NTBbGlk0a rVTV6q7C9vljxgy8cscNf0pIcKmrnu5/6PvY6tNL19ixWMhTOCIFn3/Unr+v17aj U867frhrhS9iv9sH/rHyW9Bpy6lNqFJ7bgWfRvhGXTMe8gUMOMpqmmimBmIAUq9S DN/5TG4UPq4Wz5qanLglosU0/r9HJyrF4Ok2o4iM2NxmYEhE7OMioaRWij9/4H1v zmPcfb4QfdR4hW8TJZvT6kQlFrTJBlZXSG6gVRYo2QidhnBeMo1RHeXGVlqmJLA= =1pa3 -----END PGP SIGNATURE----- --oj4kGyHlBMXGt3Le--