From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XI0at-000424-SB for qemu-devel@nongnu.org; Thu, 14 Aug 2014 15:21:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XI0ap-0004z7-9B for qemu-devel@nongnu.org; Thu, 14 Aug 2014 15:21:51 -0400 Date: Thu, 14 Aug 2014 21:22:14 +0200 From: "Michael S. Tsirkin" Message-ID: <20140814192214.GB11232@redhat.com> References: <1408032488-11096-1-git-send-email-mst@redhat.com> <1408032488-11096-8-git-send-email-mst@redhat.com> <20140814185753.GL3011@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140814185753.GL3011@thinpad.lan.raisama.net> Subject: Re: [Qemu-devel] [PULL 07/12] numa: show hex number in error message for consistency and prefix them with 0x List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Peter Maydell , Hu Tao , qemu-stable@nongnu.org, qemu-devel@nongnu.org, Anthony Liguori , Igor Mammedov , Paolo Bonzini On Thu, Aug 14, 2014 at 03:57:53PM -0300, Eduardo Habkost wrote: > On Thu, Aug 14, 2014 at 06:09:03PM +0200, Michael S. Tsirkin wrote: > > From: Hu Tao > > > > The error messages before and after patch are: > > > > before: > > qemu-system-x86_64: total memory for NUMA nodes (134217728) should equal RAM size (20000000) > > > > after: > > qemu-system-x86_64: total memory for NUMA nodes (0x8000000) should equal RAM size (0x20000000) > > Why hex? Why not change both to decimal? Reasonable number is usually very large and a power of 2, hex is easier to read. > -- > Eduardo