From: Stefan Hajnoczi <stefanha@redhat.com>
To: Maria Kustova <maxa@catit.be>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
Maria Kustova <maria.k@catit.be>
Subject: Re: [Qemu-devel] [PATCH V4 3/3] layout: Add generators of L1/L2 tables
Date: Thu, 14 Aug 2014 21:00:51 +0100 [thread overview]
Message-ID: <20140814200051.GB27302@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <e98fae93264f674586f3f921115bd7e5a8dcc20d.1407754480.git.maria.k@catit.be>
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Mon, Aug 11, 2014 at 03:01:10PM +0400, Maria Kustova wrote:
> @@ -126,63 +187,59 @@ class Image(object):
> ['>I', 96, 4, 'refcount_order'],
> ['>I', 100, 0, 'header_length']
> ]
> - v_header = FieldsList(meta_header)
> + self.header = FieldsList(meta_header)
Formerly static methods are being changed to regular methods (they take
a 'self' argument). This introduces a lot of noise in the patch.
Please make changes like this in a separate patch so it is easier to
review the L1/L2 table changes in isolation without all the other code
changes.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-08-14 20:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 11:01 [Qemu-devel] [PATCH V4 0/3] image-fuzzer: Support L1/L2 tables in the qcow2 image generator Maria Kustova
2014-08-11 11:01 ` [Qemu-devel] [PATCH V4 1/3] docs: Expand the list of supported image elements with L1/L2 tables Maria Kustova
2014-08-11 11:01 ` [Qemu-devel] [PATCH V4 2/3] fuzz: Add fuzzing functions for L1/L2 table entries Maria Kustova
2014-08-11 11:01 ` [Qemu-devel] [PATCH V4 3/3] layout: Add generators of L1/L2 tables Maria Kustova
2014-08-14 20:00 ` Stefan Hajnoczi [this message]
2014-08-14 20:01 ` [Qemu-devel] [PATCH V4 0/3] image-fuzzer: Support L1/L2 tables in the qcow2 image generator Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814200051.GB27302@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=maria.k@catit.be \
--cc=maxa@catit.be \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).