From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XI1Cp-0005l0-Jx for qemu-devel@nongnu.org; Thu, 14 Aug 2014 16:01:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XI1Cj-0001Pw-FS for qemu-devel@nongnu.org; Thu, 14 Aug 2014 16:01:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XI1Cj-0001Pp-7K for qemu-devel@nongnu.org; Thu, 14 Aug 2014 16:00:57 -0400 Date: Thu, 14 Aug 2014 21:00:51 +0100 From: Stefan Hajnoczi Message-ID: <20140814200051.GB27302@stefanha-thinkpad.redhat.com> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UHN/qo2QbUvPLonB" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH V4 3/3] layout: Add generators of L1/L2 tables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Maria Kustova Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, Maria Kustova --UHN/qo2QbUvPLonB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 11, 2014 at 03:01:10PM +0400, Maria Kustova wrote: > @@ -126,63 +187,59 @@ class Image(object): > ['>I', 96, 4, 'refcount_order'], > ['>I', 100, 0, 'header_length'] > ] > - v_header = FieldsList(meta_header) > + self.header = FieldsList(meta_header) Formerly static methods are being changed to regular methods (they take a 'self' argument). This introduces a lot of noise in the patch. Please make changes like this in a separate patch so it is easier to review the L1/L2 table changes in isolation without all the other code changes. Reviewed-by: Stefan Hajnoczi --UHN/qo2QbUvPLonB Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT7RVzAAoJEJykq7OBq3PIb2oIAIaL1JkwbYugEUuPHELEJMeh 1IxtfHS9K59jqMb685ejar2nlhJWQXuDHBcv25PqhzarRTsl/8wjrbo97jFi6NqS xJJN/U1KcR7AgwinXX54s09X3f2IyKvY4UqdYJjCWKSyeq6Q5NP5nJCyo9Pt0cY5 H7jJow+CV0k7jSsYA/Woxk1mQYTRhzBn0mIqN1edT/hei071Zab6n6HdOxOnc5p6 TwCi3dYzCHtICgU7Ohn+gbYP9CT3OolW3xDzsPHH9WehmWIyF1NmjSHzEyRbxVce ba5moi8Uq8GUl0InHoYPnoMXL1pnmIb8Y0elJQ+HReu+Ko6dXJsZKvGU7idlG4A= =m/Cp -----END PGP SIGNATURE----- --UHN/qo2QbUvPLonB--