From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XICAc-00083t-UC for qemu-devel@nongnu.org; Fri, 15 Aug 2014 03:43:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XICAY-00072h-7X for qemu-devel@nongnu.org; Fri, 15 Aug 2014 03:43:30 -0400 Received: from afflict.kos.to ([92.243.29.197]:57395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XICAY-00072c-12 for qemu-devel@nongnu.org; Fri, 15 Aug 2014 03:43:26 -0400 Date: Fri, 15 Aug 2014 10:43:24 +0300 From: Riku Voipio Message-ID: <20140815074324.GA17962@afflict.kos.to> References: <1407847054-672-1-git-send-email-stefanha@redhat.com> <1407847054-672-2-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1407847054-672-2-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] qapi.py: avoid Python 2.5+ any() function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Andreas Faerber , Markus Armbruster On Tue, Aug 12, 2014 at 01:37:33PM +0100, Stefan Hajnoczi wrote: > There is one instance of any() in qapi.py that breaks builds on older > distros that ship Python 2.4 (like RHEL5): > > GEN qmp-commands.h > Traceback (most recent call last): > File "build/scripts/qapi-commands.py", line 445, in ? > exprs = parse_schema(input_file) > File "build/scripts/qapi.py", line 329, in parse_schema > schema = QAPISchema(open(input_file, "r")) > File "build/scripts/qapi.py", line 110, in __init__ > if any(include_path == elem[1] > NameError: global name 'any' is not defined I tried building on RHEL5, and this patch gets a bit more forward. However further down the build I get a similar error: Traceback (most recent call last): File "/build/qemu/scripts/tracetool.py", line 139, in ? main(sys.argv) File "/build/qemu/scripts/tracetool.py", line 134, in main binary=binary, probe_prefix=probe_prefix) File "/build/qemu/scripts/tracetool/__init__.py", line 267, in generate backend = tracetool.backend.Wrapper(backends, format) File "/build/qemu/scripts/tracetool/backend/__init__.py", line 105, in __init__ assert all(exists(backend) for backend in self._backends) semi-related - since I'm building --disable-system --disable-tools --enable-user, is there any benefit of tracetool for this build config? Riku > Signed-off-by: Stefan Hajnoczi > --- > scripts/qapi.py | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/scripts/qapi.py b/scripts/qapi.py > index f2c6d1f..77d46aa 100644 > --- a/scripts/qapi.py > +++ b/scripts/qapi.py > @@ -107,10 +107,10 @@ class QAPISchema: > 'Expected a file name (string), got: %s' > % include) > include_path = os.path.join(self.input_dir, include) > - if any(include_path == elem[1] > - for elem in self.include_hist): > - raise QAPIExprError(expr_info, "Inclusion loop for %s" > - % include) > + for elem in self.include_hist: > + if include_path == elem[1]: > + raise QAPIExprError(expr_info, "Inclusion loop for %s" > + % include) > # skip multiple include of the same file > if include_path in previously_included: > continue > -- > 1.9.3 >