From: Christoffer Dall <christoffer.dall@linaro.org>
To: Sergey Fedorov <serge.fdrv@gmail.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Marcel Apfelbaum" <marcel.a@redhat.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/intc/arm_gic: honor target mask in gic_update()
Date: Fri, 15 Aug 2014 13:57:06 +0200 [thread overview]
Message-ID: <20140815115706.GV10550@cbox> (raw)
In-Reply-To: <1407947471-26981-1-git-send-email-serge.fdrv@gmail.com>
On Wed, Aug 13, 2014 at 08:31:11PM +0400, Sergey Fedorov wrote:
> Take IRQ target mask into account when determining the highest priority
> pending interrupt.
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> ---
> hw/intc/arm_gic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
> index 1532ef9..a5ad7b9 100644
> --- a/hw/intc/arm_gic.c
> +++ b/hw/intc/arm_gic.c
> @@ -66,7 +66,8 @@ void gic_update(GICState *s)
> best_prio = 0x100;
> best_irq = 1023;
> for (irq = 0; irq < s->num_irq; irq++) {
> - if (GIC_TEST_ENABLED(irq, cm) && gic_test_pending(s, irq, cm)) {
> + if (GIC_TEST_ENABLED(irq, cm) && gic_test_pending(s, irq, cm) &&
> + (irq < GIC_INTERNAL || GIC_TARGET(irq) & cm)) {
> if (GIC_GET_PRIORITY(irq, cpu) < best_prio) {
> best_prio = GIC_GET_PRIORITY(irq, cpu);
> best_irq = irq;
> --
> 1.9.1
>
Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
next prev parent reply other threads:[~2014-08-15 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 16:31 [Qemu-devel] [PATCH] hw/intc/arm_gic: honor target mask in gic_update() Sergey Fedorov
2014-08-15 11:57 ` Christoffer Dall [this message]
2014-08-25 9:41 ` Sergey Fedorov
2014-08-29 13:25 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140815115706.GV10550@cbox \
--to=christoffer.dall@linaro.org \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=marcel.a@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=serge.fdrv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).