Re: [Qemu-devel] [PATCH v5 1/2] qapi: add read-pattern enum for quorum

["Benoît Canet" <benoit.canet@irqsave.net>]

The Friday 15 Aug 2014 à 13:05:16 (+0800), Liu Yuan wrote :
> Cc: Eric Blake <eblake@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> ---
>  qapi/block-core.json | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index e378653..42033d9 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1384,6 +1384,19 @@
>              'raw': 'BlockdevRef' } }
>  
>  ##
> +# @QuorumReadPattern
> +#
> +# An enumeration of quorum read patterns.
> +#
> +# @quorum: read all the children and do a quorum vote on reads
> +#
> +# @fifo: read only from the first child that has not failed
> +#
> +# Since: 2.2
> +##
> +{ 'enum': 'QuorumReadPattern', 'data': [ 'quorum', 'fifo' ] }
> +
> +##
>  # @BlockdevOptionsQuorum
>  #
>  # Driver specific block device options for Quorum
> @@ -1398,12 +1411,17 @@
>  # @rewrite-corrupted: #optional rewrite corrupted data when quorum is reached
>  #                     (Since 2.1)
>  #
> +# @read-pattern: #optional choose read pattern and set to quorum by default
> +#                (Since 2.2)
> +#
>  # Since: 2.0
>  ##
>  { 'type': 'BlockdevOptionsQuorum',
>    'data': { '*blkverify': 'bool',
>              'children': [ 'BlockdevRef' ],
> -            'vote-threshold': 'int', '*rewrite-corrupted': 'bool' } }
> +            'vote-threshold': 'int',
> +            '*rewrite-corrupted': 'bool',
> +            '*read-pattern': 'QuorumReadPattern' } }
>  
>  ##
>  # @BlockdevOptions
> -- 
> 1.9.1
> 
> 
Reviewed-by: Benoît Canet <benoit.canet@nodalink.com>