From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49826)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XIGBW-0003V3-ST
	for qemu-devel@nongnu.org; Fri, 15 Aug 2014 08:00:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XIGBP-0007xi-En
	for qemu-devel@nongnu.org; Fri, 15 Aug 2014 08:00:42 -0400
Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:41947 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XIGBP-0007xe-7Q
	for qemu-devel@nongnu.org; Fri, 15 Aug 2014 08:00:35 -0400
Date: Fri, 15 Aug 2014 13:59:43 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140815115942.GC13567@irqsave.net>
References: <1408079117-15064-1-git-send-email-namei.unix@gmail.com>
	<1408079117-15064-2-git-send-email-namei.unix@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1408079117-15064-2-git-send-email-namei.unix@gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5 1/2] qapi: add read-pattern enum for
 quorum
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu Yuan <namei.unix@gmail.com>
Cc: qemu-devel@nongnu.org

The Friday 15 Aug 2014 =E0 13:05:16 (+0800), Liu Yuan wrote :
> Cc: Eric Blake <eblake@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> ---
>  qapi/block-core.json | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
>=20
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index e378653..42033d9 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1384,6 +1384,19 @@
>              'raw': 'BlockdevRef' } }
> =20
>  ##
> +# @QuorumReadPattern
> +#
> +# An enumeration of quorum read patterns.
> +#
> +# @quorum: read all the children and do a quorum vote on reads
> +#
> +# @fifo: read only from the first child that has not failed
> +#
> +# Since: 2.2
> +##
> +{ 'enum': 'QuorumReadPattern', 'data': [ 'quorum', 'fifo' ] }
> +
> +##
>  # @BlockdevOptionsQuorum
>  #
>  # Driver specific block device options for Quorum
> @@ -1398,12 +1411,17 @@
>  # @rewrite-corrupted: #optional rewrite corrupted data when quorum is =
reached
>  #                     (Since 2.1)
>  #
> +# @read-pattern: #optional choose read pattern and set to quorum by de=
fault
> +#                (Since 2.2)
> +#
>  # Since: 2.0
>  ##
>  { 'type': 'BlockdevOptionsQuorum',
>    'data': { '*blkverify': 'bool',
>              'children': [ 'BlockdevRef' ],
> -            'vote-threshold': 'int', '*rewrite-corrupted': 'bool' } }
> +            'vote-threshold': 'int',
> +            '*rewrite-corrupted': 'bool',
> +            '*read-pattern': 'QuorumReadPattern' } }
> =20
>  ##
>  # @BlockdevOptions
> --=20
> 1.9.1
>=20
>=20
Reviewed-by: Beno=EEt Canet <benoit.canet@nodalink.com>