From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33157)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XIHF6-0000Yt-Vf
	for qemu-devel@nongnu.org; Fri, 15 Aug 2014 09:08:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XIHF0-0005K2-MW
	for qemu-devel@nongnu.org; Fri, 15 Aug 2014 09:08:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47648)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XIHF0-0005Jw-Do
	for qemu-devel@nongnu.org; Fri, 15 Aug 2014 09:08:22 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7FD8K28010777
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 15 Aug 2014 09:08:21 -0400
Date: Fri, 15 Aug 2014 15:08:18 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140815130818.GD3770@noname.redhat.com>
References: <1403294254-10245-1-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1403294254-10245-1-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.2 v3 0/3] nbd: Adapt for dataplane
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 20.06.2014 um 21:57 hat Max Reitz geschrieben:
> For the NBD server to work with dataplane, it needs to correctly access
> the exported BDS. It makes the most sense to run both in the same
> AioContext, therefore this series implements methods for tracking a
> BDS's AioContext and makes NBD make use of this for keeping the clients
> connected to that BDS in the same AioContext.
> 
> This series breaks compilation of NBD on Windows, because
> aio_set_fd_handler() is not available there yet. It should therefore not
> be merged until that function is available (which will probably not
> happen before qemu 2.2).
> 
> 
> v3:
>  - Patch 1: Drop aio_notify(), because aio_set_fd_handler() will call it
>    anyway [Stefan]
> 
> v2:
>  - Patch 1: Drop NBDClient::restart_write; checking whether
>    NBDClient::send_coroutine is not NULL suffices [Paolo]

Dropped from the block branch because it breaks the win32 build:

nbd.c: In function 'nbd_set_handlers':
nbd.c:1323:9: warning: implicit declaration of function 'aio_set_fd_handler' [-Wimplicit-function-declaration]
         aio_set_fd_handler(client->exp->ctx, client->sock,
         ^
nbd.c:1323:9: warning: nested extern declaration of 'aio_set_fd_handler' [-Wnested-externs]

And the resulting undefined references during linking.

Kevin