From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIL6Q-0003MB-T4 for qemu-devel@nongnu.org; Fri, 15 Aug 2014 13:15:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XIL6H-0002k0-9G for qemu-devel@nongnu.org; Fri, 15 Aug 2014 13:15:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIL6H-0002ju-0V for qemu-devel@nongnu.org; Fri, 15 Aug 2014 13:15:37 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7FHFa2Y025164 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 15 Aug 2014 13:15:36 -0400 Date: Fri, 15 Aug 2014 18:15:34 +0100 From: Stefan Hajnoczi Message-ID: <20140815171534.GA14646@stefanha-thinkpad.redhat.com> References: <1403294254-10245-1-git-send-email-mreitz@redhat.com> <20140815130818.GD3770@noname.redhat.com> <53EE0BC4.50705@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sdtB3X0nJg68CQEu" Content-Disposition: inline In-Reply-To: <53EE0BC4.50705@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.2 v3 0/3] nbd: Adapt for dataplane List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , Paolo Bonzini , qemu-devel@nongnu.org --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 15, 2014 at 03:31:48PM +0200, Max Reitz wrote: > On 15.08.2014 15:08, Kevin Wolf wrote: > >Am 20.06.2014 um 21:57 hat Max Reitz geschrieben: > >>For the NBD server to work with dataplane, it needs to correctly access > >>the exported BDS. It makes the most sense to run both in the same > >>AioContext, therefore this series implements methods for tracking a > >>BDS's AioContext and makes NBD make use of this for keeping the clients > >>connected to that BDS in the same AioContext. > >> > >>This series breaks compilation of NBD on Windows, because > >>aio_set_fd_handler() is not available there yet. It should therefore not > >>be merged until that function is available (which will probably not > >>happen before qemu 2.2). > >> > >> > >>v3: > >> - Patch 1: Drop aio_notify(), because aio_set_fd_handler() will call = it > >> anyway [Stefan] > >> > >>v2: > >> - Patch 1: Drop NBDClient::restart_write; checking whether > >> NBDClient::send_coroutine is not NULL suffices [Paolo] > >Dropped from the block branch because it breaks the win32 build: > > > >nbd.c: In function 'nbd_set_handlers': > >nbd.c:1323:9: warning: implicit declaration of function 'aio_set_fd_hand= ler' [-Wimplicit-function-declaration] > > aio_set_fd_handler(client->exp->ctx, client->sock, > > ^ > >nbd.c:1323:9: warning: nested extern declaration of 'aio_set_fd_handler'= [-Wnested-externs] > > > >And the resulting undefined references during linking. >=20 > As stated by the cover letter you're replying to. :-) Sorry I did not pay > enough attention when you merged this series to your tree, I should have > explicitly warned you. >=20 > Right, we need to implement aio_set_fd_handler() for the win32/win64 build > before this series can really be merged. Paolo said this could be done un= til > 2.2, so that's why this series is marked "for-2.2". I guess I'll have to > keep a close look on qemu-devel whenever someone posts something resembli= ng > aio_set_fd_handler() for win32/win64. Paolo's "[PATCH 00/25] AioContext & threadpool" is what we need. Waiting for him to respin. Stefan --sdtB3X0nJg68CQEu Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT7kA2AAoJEJykq7OBq3PIpaIH/j/jCKDQgdTiwci/kdabbfa+ R0Ube5FKpdQXYNphIf6aoSBIMNx5txz9trNtSqEXhUcCY+xb12IO2L6cGeOnoSyn U3Cs/ox7xSYGMdrBj4+nDqZ1fo/yXvRonuiRxMgzOYUM9a2dCs5uV8UJQ3yxjPxi ZVcexR8De7JsoVo5m4Dk5VLHJMcNTPatoYlxKMzA2blDPP0kOVkzhmmpGuqiwY+P EdFbjVd0/xWISz2BoVFoAzuqajVCIAkeZ3BajpZEDbHYUNungpxQFqUGf1KUFcCa S9Pm4gsFiYhSy2NBNoCI4TLgJgz7NOG7HsEkROk0RsW1Z+rW3xXZtW2xWetYoSs= =ii4u -----END PGP SIGNATURE----- --sdtB3X0nJg68CQEu--