From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJMM5-0001m9-CP for qemu-devel@nongnu.org; Mon, 18 Aug 2014 08:48:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJMLz-0003s3-Av for qemu-devel@nongnu.org; Mon, 18 Aug 2014 08:48:09 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:62906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJMLz-0003rz-4x for qemu-devel@nongnu.org; Mon, 18 Aug 2014 08:48:03 -0400 Received: by mail-la0-f46.google.com with SMTP id b8so4420317lan.5 for ; Mon, 18 Aug 2014 05:48:02 -0700 (PDT) Date: Mon, 18 Aug 2014 14:48:15 +0200 From: Christoffer Dall Message-ID: <20140818124815.GD19635@cbox> References: <1408218501-22326-1-git-send-email-adam@os.inf.tu-dresden.de> <1408218501-22326-4-git-send-email-adam@os.inf.tu-dresden.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1408218501-22326-4-git-send-email-adam@os.inf.tu-dresden.de> Subject: Re: [Qemu-devel] [PATCH 3/3] arm_gic: Do not force PPIs to edge-triggered mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Adam Lackorzynski Cc: qemu-devel@nongnu.org On Sat, Aug 16, 2014 at 09:48:21PM +0200, Adam Lackorzynski wrote: > Only SGIs must be WI, done by forcing them to their default > (edge-triggered). > > Signed-off-by: Adam Lackorzynski > --- > hw/intc/arm_gic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c > index e546647..55019c9 100644 > --- a/hw/intc/arm_gic.c > +++ b/hw/intc/arm_gic.c > @@ -558,7 +558,7 @@ static void gic_dist_writeb(void *opaque, hwaddr offset, > irq = (offset - 0xc00) * 4 + GIC_BASE_IRQ; > if (irq >= s->num_irq) > goto bad_reg; > - if (irq < GIC_INTERNAL) > + if (irq < GIC_NR_SGIS) > value |= 0xaa; > for (i = 0; i < 4; i++) { > if (s->revision == REV_11MPCORE || s->revision == REV_NVIC) { > -- > 2.1.0.rc1 > where do we ensure that the SGIs are actually configured as edge-triggered when creating the gic? -Christoffer