From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJMYn-0006Uj-Ai for qemu-devel@nongnu.org; Mon, 18 Aug 2014 09:01:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJMYh-0008Gl-NP for qemu-devel@nongnu.org; Mon, 18 Aug 2014 09:01:17 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:45162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJMYh-0008Ge-Gg for qemu-devel@nongnu.org; Mon, 18 Aug 2014 09:01:11 -0400 Received: by mail-lb0-f180.google.com with SMTP id v6so4150725lbi.11 for ; Mon, 18 Aug 2014 06:01:10 -0700 (PDT) Date: Mon, 18 Aug 2014 15:01:22 +0200 From: Christoffer Dall Message-ID: <20140818130122.GF19635@cbox> References: <1408218501-22326-1-git-send-email-adam@os.inf.tu-dresden.de> <1408218501-22326-4-git-send-email-adam@os.inf.tu-dresden.de> <20140818124815.GD19635@cbox> <20140818125247.GB4673@os.inf.tu-dresden.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140818125247.GB4673@os.inf.tu-dresden.de> Subject: Re: [Qemu-devel] [PATCH 3/3] arm_gic: Do not force PPIs to edge-triggered mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Adam Lackorzynski Cc: qemu-devel@nongnu.org On Mon, Aug 18, 2014 at 02:52:47PM +0200, Adam Lackorzynski wrote: > On Mon Aug 18, 2014 at 14:48:15 +0200, Christoffer Dall wrote: > > On Sat, Aug 16, 2014 at 09:48:21PM +0200, Adam Lackorzynski wrote: > > > Only SGIs must be WI, done by forcing them to their default > > > (edge-triggered). > > > > > > Signed-off-by: Adam Lackorzynski > > > --- > > > hw/intc/arm_gic.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c > > > index e546647..55019c9 100644 > > > --- a/hw/intc/arm_gic.c > > > +++ b/hw/intc/arm_gic.c > > > @@ -558,7 +558,7 @@ static void gic_dist_writeb(void *opaque, hwaddr offset, > > > irq = (offset - 0xc00) * 4 + GIC_BASE_IRQ; > > > if (irq >= s->num_irq) > > > goto bad_reg; > > > - if (irq < GIC_INTERNAL) > > > + if (irq < GIC_NR_SGIS) > > > value |= 0xaa; > > > for (i = 0; i < 4; i++) { > > > if (s->revision == REV_11MPCORE || s->revision == REV_NVIC) { > > > -- > > > 2.1.0.rc1 > > > > > > > where do we ensure that the SGIs are actually configured as > > edge-triggered when creating the gic? > > It's setup in arm_gic_common_reset() in arm_gic_common.c. > (Looks like I should add another change to use GIC_NR_SGIS there too.) > That would be good, for this patch: Acked-by: Christoffer Dall Thanks!