From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48900)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XJMjm-0001p3-UW
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 09:12:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XJMjg-0003M6-Lw
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 09:12:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65503)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XJMjg-0003Kb-Ca
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 09:12:32 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7IDCVBH012848
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 18 Aug 2014 09:12:31 -0400
Date: Mon, 18 Aug 2014 14:12:29 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140818131229.GB1273@stefanha-thinkpad.redhat.com>
References: <1408050186-27800-1-git-send-email-jsnow@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="UHN/qo2QbUvPLonB"
Content-Disposition: inline
In-Reply-To: <1408050186-27800-1-git-send-email-jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com


--UHN/qo2QbUvPLonB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Aug 14, 2014 at 05:03:06PM -0400, John Snow wrote:
> @@ -162,10 +173,10 @@ static void ide_identify(IDEState *s)
>      }
>      put_le16(p + 88, 0x3f | (1 << 13)); /* udma5 set and supported */
>      put_le16(p + 93, 1 | (1 << 14) | 0x2000);
> -    put_le16(p + 100, s->nb_sectors);
> -    put_le16(p + 101, s->nb_sectors >> 16);
> -    put_le16(p + 102, s->nb_sectors >> 32);
> -    put_le16(p + 103, s->nb_sectors >> 48);
> +    /* *(p + 100) := nb_sectors       -- see ide_identify_size */
> +    /* *(p + 101) := nb_sectors >> 16 -- see ide_identify_size */
> +    /* *(p + 102) := nb_sectors >> 32 -- see ide_identify_size */
> +    /* *(p + 103) := nb_sectors >> 48 -- see ide_identify_size */

These comments bitrot easily.  I'd prefer not to have them, but not a
reason to respin:

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--UHN/qo2QbUvPLonB
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJT8fu9AAoJEJykq7OBq3PIoHgH/ivNOwf/+Nxh3Yd4rYPo8x6W
0G1CI0oYraL3HDrueMLE3dopcot1p4dEdwNKrDzRpvDiEXQV1skQCE0OUjUSUUbL
0KLNnT3bBEwC8CsF5LqMsnRtUlGP3LdeSkeNJ0bSfZwHzWpIQJH0dCytKnn5qKrD
zXPV3OJbdhj6k02qykkBSIVDPRII2+7Y53u+W9UsR9DU4atL6smr68ZXmMmVWeCT
EbrL5PczNj2RyW65z4Ulw29ZieoAb6iSMxebLu4CSH/0I4grXwhZCqS0COT8FguR
EQfvClCCAGBhb2tUBhI8sUnsHqSRIj9WIvY8tHSZEqJwPeX0ObIA4RUrQ/tCZO0=
=OngZ
-----END PGP SIGNATURE-----

--UHN/qo2QbUvPLonB--