From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJNhB-0000FC-Lu for qemu-devel@nongnu.org; Mon, 18 Aug 2014 10:14:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJNh5-0007h6-It for qemu-devel@nongnu.org; Mon, 18 Aug 2014 10:14:01 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:55385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJNh5-0007gA-C9 for qemu-devel@nongnu.org; Mon, 18 Aug 2014 10:13:55 -0400 Received: by mail-la0-f48.google.com with SMTP id gl10so4632388lab.35 for ; Mon, 18 Aug 2014 07:13:54 -0700 (PDT) Date: Mon, 18 Aug 2014 16:14:07 +0200 From: Christoffer Dall Message-ID: <20140818141407.GH19635@cbox> References: <1408367280-5093-1-git-send-email-adam@os.inf.tu-dresden.de> <1408367280-5093-5-git-send-email-adam@os.inf.tu-dresden.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1408367280-5093-5-git-send-email-adam@os.inf.tu-dresden.de> Subject: Re: [Qemu-devel] [PATCH 4/4] arm_gic: Use GIC_NR_SGIS constant List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Adam Lackorzynski Cc: qemu-devel@nongnu.org On Mon, Aug 18, 2014 at 03:08:00PM +0200, Adam Lackorzynski wrote: > Use constant rather than a plain number. > > Signed-off-by: Adam Lackorzynski > --- > hw/intc/arm_gic_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/intc/arm_gic_common.c b/hw/intc/arm_gic_common.c > index 6d884ec..18b01ba 100644 > --- a/hw/intc/arm_gic_common.c > +++ b/hw/intc/arm_gic_common.c > @@ -128,7 +128,7 @@ static void arm_gic_common_reset(DeviceState *dev) > s->running_priority[i] = 0x100; > s->cpu_enabled[i] = false; > } > - for (i = 0; i < 16; i++) { > + for (i = 0; i < GIC_NR_SGIS; i++) { > GIC_SET_ENABLED(i, ALL_CPU_MASK); > GIC_SET_EDGE_TRIGGER(i); > } > -- > 2.1.0.rc1 > Acked-by: Christoffer Dall