From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJSqI-0003zG-2C for qemu-devel@nongnu.org; Mon, 18 Aug 2014 15:43:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJSqB-00074E-Rt for qemu-devel@nongnu.org; Mon, 18 Aug 2014 15:43:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJSqB-000748-JF for qemu-devel@nongnu.org; Mon, 18 Aug 2014 15:43:39 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7IJhbUp029563 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 18 Aug 2014 15:43:38 -0400 Date: Mon, 18 Aug 2014 15:43:35 -0400 From: Jeff Cody Message-ID: <20140818194335.GB2627@localhost.localdomain> References: <1408378243-19713-1-git-send-email-armbru@redhat.com> <1408378243-19713-2-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1408378243-19713-2-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/4] block: Use g_new() & friends where that makes obvious sense List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com On Mon, Aug 18, 2014 at 06:10:40PM +0200, Markus Armbruster wrote: > g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, > for two reasons. One, it catches multiplication overflowing size_t. > Two, it returns T * rather than void *, which lets the compiler catch > more type errors. > > Patch created with Coccinelle, with two manual changes on top: > > * Add const to bdrv_iterate_format() to keep the types straight > > * Convert the allocation in bdrv_drop_intermediate(), which Coccinelle > inexplicably misses > > Coccinelle semantic patch: > > @@ > type T; > @@ > -g_malloc(sizeof(T)) > +g_new(T, 1) > @@ > type T; > @@ > -g_try_malloc(sizeof(T)) > +g_try_new(T, 1) > @@ > type T; > @@ > -g_malloc0(sizeof(T)) > +g_new0(T, 1) > @@ > type T; > @@ > -g_try_malloc0(sizeof(T)) > +g_try_new0(T, 1) > @@ > type T; > expression n; > @@ > -g_malloc(sizeof(T) * (n)) > +g_new(T, n) > @@ > type T; > expression n; > @@ > -g_try_malloc(sizeof(T) * (n)) > +g_try_new(T, n) > @@ > type T; > expression n; > @@ > -g_malloc0(sizeof(T) * (n)) > +g_new0(T, n) > @@ > type T; > expression n; > @@ > -g_try_malloc0(sizeof(T) * (n)) > +g_try_new0(T, n) > @@ > type T; > expression p, n; > @@ > -g_realloc(p, sizeof(T) * (n)) > +g_renew(T, p, n) > @@ > type T; > expression p, n; > @@ > -g_try_realloc(p, sizeof(T) * (n)) > +g_try_renew(T, p, n) > > Signed-off-by: Markus Armbruster > --- > block-migration.c | 6 +++--- > block.c | 14 +++++++------- > block/archipelago.c | 6 +++--- > block/gluster.c | 8 ++++---- > block/iscsi.c | 2 +- > block/nfs.c | 2 +- > block/qcow.c | 2 +- > block/qcow2-cluster.c | 2 +- > block/qcow2-refcount.c | 8 ++++---- > block/qcow2-snapshot.c | 8 ++++---- > block/raw-posix.c | 2 +- > block/rbd.c | 4 ++-- > block/sheepdog.c | 4 ++-- > block/vdi.c | 2 +- > block/vhdx.c | 4 ++-- > block/vmdk.c | 7 +++---- > block/vvfat.c | 2 +- > blockdev-nbd.c | 2 +- > blockdev.c | 2 +- > hw/ide/ahci.c | 2 +- > qemu-io-cmds.c | 2 +- > qemu-io.c | 2 +- > 22 files changed, 46 insertions(+), 47 deletions(-) [...] Reviewed-by: Jeff Cody