From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43182)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1XJT5E-0001KF-Db
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 15:59:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1XJT58-0002hY-7t
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 15:59:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41197)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1XJT57-0002hL-Vl
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 15:59:06 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7IJx4rl011239
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 18 Aug 2014 15:59:04 -0400
Date: Mon, 18 Aug 2014 15:59:02 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20140818195902.GD2627@localhost.localdomain>
References: <1408378243-19713-1-git-send-email-armbru@redhat.com>
	<1408378243-19713-4-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1408378243-19713-4-git-send-email-armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/4] qemu-io-cmds: g_renew() can't fail,
 bury dead error handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com

On Mon, Aug 18, 2014 at 06:10:42PM +0200, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qemu-io-cmds.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
> index afd8867..b224ede 100644
> --- a/qemu-io-cmds.c
> +++ b/qemu-io-cmds.c
> @@ -115,22 +115,13 @@ static char **breakline(char *input, int *count)
>      int c = 0;
>      char *p;
>      char **rval = g_new0(char *, 1);
> -    char **tmp;
>  
>      while (rval && (p = qemu_strsep(&input, " ")) != NULL) {
>          if (!*p) {
>              continue;
>          }
>          c++;
> -        tmp = g_renew(char *, rval, (c + 1));
> -        if (!tmp) {
> -            g_free(rval);
> -            rval = NULL;
> -            c = 0;
> -            break;
> -        } else {
> -            rval = tmp;
> -        }
> +        rval = g_renew(char *, rval, (c + 1));
>          rval[c - 1] = p;
>          rval[c] = NULL;
>      }
> -- 
> 1.9.3
> 
>

Reviewed-by: Jeff Cody <jcody@redhat.com>