From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJTAJ-0001He-OM for qemu-devel@nongnu.org; Mon, 18 Aug 2014 16:04:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJTAD-0004G2-IZ for qemu-devel@nongnu.org; Mon, 18 Aug 2014 16:04:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJTAD-0004Fw-Bc for qemu-devel@nongnu.org; Mon, 18 Aug 2014 16:04:21 -0400 Date: Mon, 18 Aug 2014 22:04:49 +0200 From: "Michael S. Tsirkin" Message-ID: <20140818200449.GB31062@redhat.com> References: <1408363934-28591-1-git-send-email-tangchen@cn.fujitsu.com> <20140818135602.GC28795@redhat.com> <53F20689.3000207@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53F20689.3000207@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.crosthwaite@xilinx.com, ehabkost@redhat.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, Tang Chen , isimatu.yasuaki@jp.fujitsu.com, imammedo@redhat.com On Mon, Aug 18, 2014 at 03:58:33PM +0200, Paolo Bonzini wrote: > Il 18/08/2014 15:56, Michael S. Tsirkin ha scritto: > > > +/* Initialize PCDIMMDevice->node to -1 so that even if user doesn't specify > > > + * any numa option, PCDIMMDevice->node won't be 0, which indicates node0. > > > + * In this case, SRAT won't be created, and guest kernel will fake a node. > > > + */ > > > > I think you simply mean > > /* default value for PCDIMMDevice->node (unless specified by user) */ > > > > > +#define NO_NODE_ID -1 > > I think a comment about the SRAT would be useful. > > Paolo OK so add: /* In this case, SRAT won't be created. */