From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39639)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1XJXXh-0007EB-HP
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 20:44:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1XJXXS-000248-NP
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 20:44:53 -0400
Date: Tue, 19 Aug 2014 10:39:49 +1000
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20140819003949.GA26479@voom.fritz.box>
References: <1408097555-28126-1-git-send-email-aik@ozlabs.ru>
	<1408097555-28126-2-git-send-email-aik@ozlabs.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp"
Content-Disposition: inline
In-Reply-To: <1408097555-28126-2-git-send-email-aik@ozlabs.ru>
Subject: Re: [Qemu-devel] [RFC PATCH v2 01/13] qom: Make
 object_child_foreach safe for objects removal
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Alex Williamson <alex.williamson@redhat.com>, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Gavin Shan <gwshan@linux.vnet.ibm.com>, Alexander Graf <agraf@suse.de>


--LQksG6bCIzRHxTLp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 15, 2014 at 08:12:23PM +1000, Alexey Kardashevskiy wrote:
> Current object_child_foreach() uses QTAILQ_FOREACH() to walk
> through children and that makes children removal from the callback
> impossible.
>=20
> This makes object_child_foreach() use QTAILQ_FOREACH_SAFE().
>=20
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Seems like a good idea to me.

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--LQksG6bCIzRHxTLp
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJT8pzVAAoJEGw4ysog2bOS7ZAP/39ahUd7kryttEvaud8emtr2
oLVvHYs5JpLOJEUrFv9S10NRXo3UIaHB1JSrlEurh9MGC/7EonIcX3FR3C33HHEl
KHvvnojgnWCH8e7sfNwJoEdEpSC0hSKuKWYDgKqhECP4yXV8quDQRCnyNKbnfMaJ
mGkOWBJKfhyEncxaCSSM3kUPvyxeFEe/OxC8QlQOBI6/ViGtalPq1fm+Zk5VQMkT
fljL0dGdSRUX0i2r1nsSxuIHAQmuEmR1zBOxNB44b0MCy7vonjAfa4e0wMbb1m23
kvP5YDaZ0en++DB0+YrsMwOuFaemV8UIwbkRuz8al17F5OsqAjLy6adKGlpzXaoz
civXXJ40fXrIV1CBjlcJ/8aPh4p5RqWmDDA9kErk1tl9qMbuhAp0AEW8HOALrnlJ
3GJGh5H4VId9hvU9h9LjwXzfoMEqEdkCmWRkj79xdASqIHKI/anxA1xVFBGfX+zy
EYvT3O7HjVsfJgPd1VcP6cRdixegRlteKVP6JUOmjwpVC1xSOVnsbdFmJX3YaGA4
YZTjRpiTCZ0Q9HT6+afjSbLiDL6sOtYr4GwXApCp6UfolwSVTUP9xYECq42FmymW
EQf9i8m28ctoQHlZgrqiXbIDGkxmRqGTJxm4RqYygOpP67qzg89XVFJhhGxEhwSh
1eF/oHm/+FbtitBmeW+M
=m6dW
-----END PGP SIGNATURE-----

--LQksG6bCIzRHxTLp--