From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1XJXXb-00076T-71
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 20:44:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1XJXXS-00024E-P6
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 20:44:47 -0400
Date: Tue, 19 Aug 2014 10:44:53 +1000
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20140819004453.GC26479@voom.fritz.box>
References: <1408097555-28126-1-git-send-email-aik@ozlabs.ru>
	<1408097555-28126-6-git-send-email-aik@ozlabs.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ZwgA9U+XZDXt4+m+"
Content-Disposition: inline
In-Reply-To: <1408097555-28126-6-git-send-email-aik@ozlabs.ru>
Subject: Re: [Qemu-devel] [RFC PATCH v2 05/13] spapr_pci: Introduce a liobn
 number generating macros
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Alex Williamson <alex.williamson@redhat.com>, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Gavin Shan <gwshan@linux.vnet.ibm.com>, Alexander Graf <agraf@suse.de>


--ZwgA9U+XZDXt4+m+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 15, 2014 at 08:12:27PM +1000, Alexey Kardashevskiy wrote:
> We are going to have multiple DMA windows per PHB and we want them to
> migrate so we need a predictable way of assigning LIOBNs.
>=20
> This introduces a macro which makes up a LIOBN from fixed prefix,
> PHB index (unique PHB id) and window number.
>=20
> This introduces a SPAPR_PCI_DMA_WINDOW_NUM() to know the window number
> from LIOBN, will be used in next patch(es) to distinguish the default
> 32bit windows from dynamic windows.
>=20
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Looks sane enough.

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--ZwgA9U+XZDXt4+m+
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJT8p4FAAoJEGw4ysog2bOSW6YQAOTh64eKIRrspTftXNBndu2i
wScf6JiixJxQd9X4nF0iU/aeRQL8eSmtpaetcfwtONKJcKkGJVxJPQTx5ilU2jFe
VomKY8winq97EPcMBLSjl5iZrIvbCbrt2P5JJHorMWmdPdwMJgB0PSgKjsiJp9pm
RXgZA02NHzpICszIWGIcF5Ks0n1m4Y84tJbg7RZWYl9tHSULtIbTH+Z/VTtCObCR
vwqZXPmdTQmQ4v7z88LYmHpN5jzUv/rMjNhGUPtdViKbKhMKIUWHYGzQ7JcAMmys
m++nuIoI539+BCd8oxSJ9Ujne1TEnzQHDf8zT/pGMv0yC1jUCuSxgcQIq64gSOeQ
T6KFLm7b8QFipMCSfBR2rYrq/gv5RYawQ8F4LgOX8pHaoyrbV53nKR4aVSNUEGFS
yuxY/nPBMab+rOhKIPgKnJYmIwx+ACwCvFgxYOtRYS4iQa2/QFhIgvmvJcE1+PLU
cZOkGM0wBKTvF6TPKKePyxaHou5bnEU/tKw9mFePsb+K5Wwr16cs4+IeOc1DnREC
OjLiI1b+lX2qtY9xsB4HOKfMgY/5DofLvEMZ1vuVw3wXSzWZK4xBYAWf8FE0q3Gl
OgKZ9a4q2AePTbbdx4TXAW2zzTNy8LkgAk6AfezY6bxVeI4mrJLXSVjbiRazr8ly
s0XhdedWg9gD4JfXhAVg
=KcGC
-----END PGP SIGNATURE-----

--ZwgA9U+XZDXt4+m+--