From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJm1u-0002AA-Fo for qemu-devel@nongnu.org; Tue, 19 Aug 2014 12:13:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJm1o-0005P7-1u for qemu-devel@nongnu.org; Tue, 19 Aug 2014 12:13:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJm1n-0005Nz-QJ for qemu-devel@nongnu.org; Tue, 19 Aug 2014 12:12:55 -0400 Date: Tue, 19 Aug 2014 17:12:49 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20140819161248.GI2383@work-vm> References: <1408399520-12778-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1408399520-12778-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [RFC 0/4] Adding -cdrom, -hd[abcd] and -drive file=... to Q35 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com * John Snow (jsnow@redhat.com) wrote: > The changes appear to work well, but where I'd like some feedback > is what should happen if people do something like: > > qemu -M q35 -drive if=ide,file=fedora.qcow2 > > The code as presented here is not going to look for or attempt to > connect IDE devices, because it is now looking for /AHCI/ devices. What happens if you try it - does it just silently ignore that -drive? The ideal would be for something to moan about unused drives so people realise why it's broken; but I seem to remember form a previous discussion it's hard to do on all platforms. Dave > > At worst, this may break a few existing scripts, but I actually think > that since the if=ide,file=... shorthand never worked to begin with, > the impact might actually be minimal. > > But since the legacy IDE interface of the ICH9 is as of yet unemulated, > the if=ide drives don't have a reasonable place to go yet. I am also > not sure what a reasonable way to handle people specifying BOTH > if=ide and if=ahci drives would be. > > John Snow (4): > blockdev: add if_get_max_devs > blockdev: add IF_AHCI to support -cdrom and -hd[a-d] > ide: update ide_drive_get to work with both PCI-IDE and AHCI > interfaces > ahci: implement -cdrom and -hd[a-d] > > blockdev.c | 18 +++++++++++++++--- > hw/i386/pc_piix.c | 2 +- > hw/i386/pc_q35.c | 4 ++++ > hw/ide/ahci.c | 17 +++++++++++++++++ > hw/ide/ahci.h | 2 ++ > hw/ide/core.c | 11 +++++++---- > include/hw/ide.h | 3 ++- > include/sysemu/blockdev.h | 3 ++- > 8 files changed, 50 insertions(+), 10 deletions(-) > > -- > 1.9.3 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK