From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XK4Kp-0004Jl-Fk for qemu-devel@nongnu.org; Wed, 20 Aug 2014 07:45:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XK4Kf-0002oP-TN for qemu-devel@nongnu.org; Wed, 20 Aug 2014 07:45:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XK4Kf-0002o9-MH for qemu-devel@nongnu.org; Wed, 20 Aug 2014 07:45:37 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KBja1Y007238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Aug 2014 07:45:36 -0400 Date: Wed, 20 Aug 2014 13:45:33 +0200 From: Kevin Wolf Message-ID: <20140820114533.GG6122@noname.redhat.com> References: <1406064567-27907-1-git-send-email-mreitz@redhat.com> <53EE25CE.4030102@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53EE25CE.4030102@redhat.com> Subject: Re: [Qemu-devel] [PATCH v10 00/14] qemu-img: Implement commit like QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Am 15.08.2014 um 17:22 hat Max Reitz geschrieben: > On 22.07.2014 23:29, Max Reitz wrote: > >qemu-img should use QMP commands whenever possible in order to ensure > >feature completeness of both online and offline image operations. For > >the "commit" command, this is relatively easy, so implement it first > >(in the hope that indeed others will follow). > > > >As qemu-img does not have access to QMP (due to QMP being intertwined > >with basically everything in qemu), we cannot directly use QMP, but at > >least use the functions the corresponding QMP commands are using (which > >would be "block-commit", in this case). > > Ping This doesn't apply cleanly any more. Kevin