Re: [Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

On Tue, Aug 19, 2014 at 03:20:06PM -0400, John Snow wrote:
> 
> 
> On 08/18/2014 09:12 AM, Stefan Hajnoczi wrote:
> >On Thu, Aug 14, 2014 at 05:03:06PM -0400, John Snow wrote:
> >>@@ -162,10 +173,10 @@ static void ide_identify(IDEState *s)
> >>      }
> >>      put_le16(p + 88, 0x3f | (1 << 13)); /* udma5 set and supported */
> >>      put_le16(p + 93, 1 | (1 << 14) | 0x2000);
> >>-    put_le16(p + 100, s->nb_sectors);
> >>-    put_le16(p + 101, s->nb_sectors >> 16);
> >>-    put_le16(p + 102, s->nb_sectors >> 32);
> >>-    put_le16(p + 103, s->nb_sectors >> 48);
> >>+    /* *(p + 100) := nb_sectors       -- see ide_identify_size */
> >>+    /* *(p + 101) := nb_sectors >> 16 -- see ide_identify_size */
> >>+    /* *(p + 102) := nb_sectors >> 32 -- see ide_identify_size */
> >>+    /* *(p + 103) := nb_sectors >> 48 -- see ide_identify_size */
> >
> >These comments bitrot easily.  I'd prefer not to have them, but not a
> >reason to respin:
> >
> >Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> >
> 
> Ping? Respin w/o comments, or is this fine?

I gave my Reviewed-by: and am not asking for a respin.

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]